Bug 108068 - [PATCH] Fix misuse of gzip(1) in sysutils/mcweject
Summary: [PATCH] Fix misuse of gzip(1) in sysutils/mcweject
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-18 01:40 UTC by Xin LI
Modified: 2007-01-19 01:50 UTC (History)
1 user (show)

See Also:


Attachments
patch-mcweject (578 bytes, text/plain)
2007-01-18 01:40 UTC, Xin LI
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xin LI freebsd_committer 2007-01-18 01:40:20 UTC
	In sysutils/mcweject, there is an instance of use of '-best'
option of gzip(1), which should be spelled as '--best'.  Because the
ports system already have '-9' in GZIP_CMD macro, the option should
be removed because it is useless.

	This would break the port after gzip(1) is replaced by a BSD
licensed one.

How-To-Repeat: 	make install
Comment 1 Edwin Groothuis freebsd_committer 2007-01-18 01:40:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->delphij

Submitter has GNATS access
Comment 2 Edwin Groothuis freebsd_committer 2007-01-18 01:40:45 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Jason Bacon 2007-01-18 15:48:18 UTC
I approve.

Thanks,

    JB

Edwin Groothuis wrote:
> Maintainer of sysutils/mcweject,
>
> Please note that PR ports/108068 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/108068
>
>
Comment 4 dfilter service freebsd_committer 2007-01-19 01:43:31 UTC
delphij     2007-01-19 01:43:26 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/mcweject    Makefile 
  Log:
  Correct a typo which will break build in a future version of
  FreeBSD.  Because we already have '-9' in our ${GZIP_CMD} we
  do not need to specify '--best' anyway.
  
  PR:             ports/108068
  Reported by:    pointyhat via kris
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.3       +1 -1      ports/sysutils/mcweject/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Xin LI freebsd_committer 2007-01-19 01:43:53 UTC
State Changed
From-To: feedback->open

Feedback received.
Comment 6 Xin LI freebsd_committer 2007-01-19 01:44:22 UTC
State Changed
From-To: open->closed

Committed, thanks!