Bug 109090 - ports/news/tin overwrites existing scripts, installs "bashed" scripts
Summary: ports/news/tin overwrites existing scripts, installs "bashed" scripts
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Andrey A. Chernov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-12 15:30 UTC by clemens fischer
Modified: 2007-02-12 18:32 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description clemens fischer 2007-02-12 15:30:03 UTC
the ports/news/tin upstream tarball contains a number of scripts
ins "./tools/" directory. some of them get installed without
checking. in particular, even when defining "WITHOUT_TIN_METAMAIL",
a script called "url_handler.sh" is installed, overwriting one from
ports/textproc/urlview. furthermore, the tin version is much inferior,
as commands to handle specific URL schemes ("netscape" for http in a
ncurses-application?!) are hardwired. some perl scripts are installed
without adding perl to RUN_DEPENDS. all scripts have shebang lines from
the linux world: they contain "/usr/bin/" as the command prefix.

the net result of all this:  installed commands cease to work, the tin
versions don't run on freebsd without tweaking.

every time tin gets updated, i have to fix "url_handler.sh"!

Fix: 

as there are RUN_DEPENDS lines for, eg. "metamail", which satisfy
tin requirements, tin must not install its tools version of, eg.
"url_handler.sh". instead, install those tools into local/libexec/tin/
or local/share/tin/, but make sure the shebang paths are correct.  i,
for one, have never used or needed any of the tools.

also, do not install tools explicitly not wanted by the user specifying
"WITHOUT_*" options.
How-To-Repeat: 
after installing tin, try other applications using "url_handler.sh", or
try any other tin-tools.
Comment 1 Edwin Groothuis freebsd_committer 2007-02-12 15:30:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ache

Over to maintainer
Comment 2 dfilter service freebsd_committer 2007-02-12 18:28:41 UTC
ache        2007-02-12 18:28:37 UTC

  FreeBSD ports repository

  Modified files:
    news/tin             Makefile pkg-plist 
  Log:
  Rename url_handler.sh to tinurl_handler.sh to avoid conflict with
  urlview port.
  
  PR:             109090
  
  Revision  Changes    Path
  1.139     +12 -5     ports/news/tin/Makefile
  1.20      +1 -1      ports/news/tin/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Andrey A. Chernov freebsd_committer 2007-02-12 18:31:53 UTC
State Changed
From-To: open->closed

Fixed by renaming url_handler.sh to tinurl_handler.sh