Bug 112253 - [PATCH] net-p2p/mldonkey: rc script broken
Summary: [PATCH] net-p2p/mldonkey: rc script broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mario Sergio Fujikawa Ferreira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-29 20:50 UTC by mwisnicki+freebsd
Modified: 2007-07-26 03:50 UTC (History)
1 user (show)

See Also:


Attachments
mldonkey-2.8.5.patch (551 bytes, patch)
2007-04-29 20:50 UTC, mwisnicki+freebsd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mwisnicki+freebsd 2007-04-29 20:50:03 UTC
Redirection depends on sh syntax which is not availible in tcsh.
Su executes command in default login shell which on some systems might be tcsh
or something else. Proposed patch explicitly calls /bin/sh.

Another solution would be to execute "daemon -f ${command} ..." instead of
redirection, which I used before with success.

Of course, same thing applies to mldonkey-devel.

Port maintainer (lioux@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77

How-To-Repeat: set ${mlnet_user} to someone with non-bourne shell
# /usr/local/etc/rc.d/mlnet start
Ambiguous output redirect.
Comment 1 Edwin Groothuis freebsd_committer 2007-04-29 20:50:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lioux

Over to maintainer
Comment 2 dfilter service freebsd_committer 2007-07-26 03:46:30 UTC
lioux       2007-07-26 02:46:25 UTC

  FreeBSD ports repository

  Modified files:
    net-p2p/mldonkey     Makefile 
    net-p2p/mldonkey/files mlnet.in wrapper.sh 
  Log:
  o Fix RC script. Make sure the shell is sh(1) when starting mlnet.
  o Bump PORTREVISION
  
  PR:             112253
  Submitted by:   Marcin Wisnicki <mwisnicki+freebsd@gmail.com>
  
  Revision  Changes    Path
  1.50      +6 -1      ports/net-p2p/mldonkey/Makefile
  1.3       +5 -4      ports/net-p2p/mldonkey/files/mlnet.in
  1.2       +1 -1      ports/net-p2p/mldonkey/files/wrapper.sh
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Mario Sergio Fujikawa Ferreira freebsd_committer 2007-07-26 03:47:25 UTC
State Changed
From-To: open->closed

Committed. Thanks!