Bug 112557 - [patch] ppp(8) lock file should not use symlink name
Summary: [patch] ppp(8) lock file should not use symlink name
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 6.2-STABLE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2007-05-10 00:40 UTC by Ighighi
Modified: 2022-10-17 12:38 UTC (History)
0 users

See Also:


Attachments
file.diff (422 bytes, patch)
2007-05-10 00:40 UTC, Ighighi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ighighi 2007-05-10 00:40:03 UTC
If ppp(8) is instructed to use /dev/modem (with "set device /dev/modem" in /etc/ppp/ppp.conf) and /dev/modem is a symbolic link to the real device, the lock file should reference the real device.  So a /var/lock/LCK..cuad0 (as in my system) should exist instead of /var/lock/LCK..modem).  Many other programs in the base and ports tree (i.e., comms/minicom that use uu_lock() (implemented in /usr/src/lib/libutil/uucplock.c) could be auto-magically patched if this function is patched instead).  A (trivial) patch to minicom similar to this one is available to anyone upon request.

Fix: Attached patch available.

Patch attached with submission follows:
Comment 1 Robert Watson freebsd_committer freebsd_triage 2008-03-09 13:07:30 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-net

Over to maintainers.
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:09 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:38:41 UTC
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>