This PR includes a patch for PR bin/111004. I've encountered caching problems with smbfs mounts when the server is case-insensitive (e.g. with 'case sensitive = no' in smb.conf on the server - no problem with 'case sensitive = yes'). Sometimes, a wrong entry is created in the cache and does not match the real filename's case on the server. This happens because the server answers : 'yes, the file exists' while it has a different case. Sometimes then, this cache entry is found and used (because of cache's case-sensitiveness), while it should not. ---- Here is a test you can perform (on a smbfs mount point) : $ touch foo && rm -f foo && touch FOO && rm -f FOO This is to purge cache entries explicitly. $ touch foo && ls -i foo 2864008422 foo $ ls -i FOO 2864008422 FOO This is OK since we should see the inode of foo. $ rm -f foo $ touch FOO && ls -i FOO 2864008422 FOO Nope, we should get another inode (2322004806) since inodes depend on the filename and the parent directory. Here, a wrong cache entry has been used. $ rm -f FOO $ touch FOO && ls -i FOO 2322004806 FOO This is OK again (because the cache entry has been explicitely removed before). ---- The attached patch is inspired from Opendarwin's code and uses the filename provided by the server when the file is found (instead of using the requested filename that may differ). This allows a better cache synchronization and solves this inode/caching problem. Moreover, I've added a fix for PR bin/111004 which now allows to modify the case of a file (to 'rename' it). This patch applies cleanly (and works ;-)) on 6.2-STABLE. It also applies to -CURRENT, but I have not tested it on this version. Best regards, -- Ganael LAPLANCHE. ganael.laplanche@martymac.com http://contribs.martymac.com Fix: Patch attached with submission follows: How-To-Repeat: Try the test above.
Hi, I've just tested the patch on -CURRENT. Everything went OK :) Ganaël LAPLANCHE ganael.laplanche@martymac.com http://www.martymac.com
Responsible Changed From-To: freebsd-bugs->freebsd-fs
Here is an updated version of the patch. It applies to svn revision 246938. -- Ganael LAPLANCHE <ganael.laplanche@martymac.org> http://www.martymac.org | http://contribs.martymac.org FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org
batch change: For bugs that match the following - Status Is In progress AND - Untouched since 2018-01-01. AND - Affects Base System OR Documentation DO: Reset to open status. Note: I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.
Keyword: patch or patch-ready – in lieu of summary line prefix: [patch] * bulk change for the keyword * summary lines may be edited manually (not in bulk). Keyword descriptions and search interface: <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>