Bug 112806 - x11/xorg doesn't build on a system with NO_RCMDS=yes
Summary: x11/xorg doesn't build on a system with NO_RCMDS=yes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-20 15:10 UTC by Olivier
Modified: 2007-07-02 19:25 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier 2007-05-20 15:10:04 UTC
When using a fresh system installed with NO_RCMDS=yes in /etc/make.conf (or /etc/src.conf for -CURRENT), x11/xorg fails to compile because of x11/xorg-apps which depends on x11/xsm which wants an rsh-like program during configure :

# cd /usr/ports/x11/xorg
# make install clean
[...]
checking for a BSD-compatible install... /usr/bin/install -c -o root -g wheel
checking for rsh... no
checking for rcmd... no
checking for remsh... no
configure: error: No rsh like program found
===>  Script "configure" failed unexpectedly.
[...]
*** Error code 1

Stop in /usr/ports/x11/xsm.
*** Error code 1

Stop in /usr/ports/x11/xorg-apps.
*** Error code 1

Stop in /usr/ports/x11/xorg.

Fix: 

Since x11/xsm can't be built without RSH, remove the line
xsm:${PORTSDIR}/x11/xsm \
from x11/xorg-apps/Makefile

Or, if you need xsm, (only a temporary workaround, very dirty) :
# touch /usr/local/bin/rsh
# cd /usr/ports/x11/xsm
# make install clean
# rm /usr/local/bin/rsh
# cd /usr/ports/x11/xorg
# make install clean

It would maybe be better for x11/xorg-apps to only install xsm if {rsh,rcmd,remsh} is present, or if NO_RCMDS isn't set.
How-To-Repeat: # echo 'NO_RCMDS=yes' >> /etc/make.conf
# cd /usr/src
# make buildworld
# make installworld
# make delete-old
# cd /usr/ports/x11/xsm
# make
Comment 1 Edwin Groothuis freebsd_committer 2007-05-20 15:10:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-x11

Over to maintainer
Comment 2 Olivier 2007-05-20 15:55:49 UTC
----- "Edwin Groothuis" <edwin@FreeBSD.org> wrote:
> Synopsis: x11/xorg doesn't build on a system with NO_RCMDS=yes
> 
> Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-x11
> Responsible-Changed-By: edwin
> Responsible-Changed-When: Sun May 20 14:10:10 UTC 2007
> Responsible-Changed-Why:
> Over to maintainer
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=112806
> _______________________________________________
> freebsd-x11@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-x11
> To unsubscribe, send any mail to "freebsd-x11-unsubscribe@freebsd.org"

Here is a patch to make x11/xsm compile without rsh and friends. The trick is to define "RSH" to something useful. In debian, RSH=/usr/bin/ssh. But if we do that, x11/xsm will be broken without SSH, SSL or CRYPTO in the base system. I used successfully "RSH=/dev/null" :)

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	/usr/ports/x11/xsm/files/patch-configure
#
echo x - /usr/ports/x11/xsm/files/patch-configure
sed 's/^X//' >/usr/ports/x11/xsm/files/patch-configure << 'END-of-/usr/ports/x11/xsm/files/patch-configure'
X--- configure.old	Sun May 20 16:29:56 2007
X+++ configure	Sun May 20 16:30:06 2007
X@@ -2915,7 +2915,7 @@
X test -z "$INSTALL_DATA" && INSTALL_DATA='${INSTALL} -m 644'
X 
X 
X-RSH=
X+RSH=/dev/null
X if [ -z $RSH ] ; then
X    # Extract the first word of "rsh", so it can be a program name with args.
X set dummy rsh; ac_word=$2
END-of-/usr/ports/x11/xsm/files/patch-configure
exit

-- 
Olivier                                                        _
                                        ASCII ribbon campaign ( )
e-mail: olivier@gid0.org        - against HTML email & vCards  X
www: http://www.gid0.org    - against proprietary attachments / \

  "Il y a seulement 10 sortes de gens dans le monde :
  ceux qui comprennent le binaire,
  et ceux qui ne le comprennent pas."
Comment 3 dfilter service freebsd_committer 2007-07-02 19:02:31 UTC
lesi        2007-07-02 18:02:22 UTC

  FreeBSD ports repository

  Modified files:
    x11/xorg-apps        Makefile 
  Log:
  Only depend on xsm if /usr/bin/rsh is present.
  
  PR:             ports/112806
  
  Revision  Changes    Path
  1.2       +4 -1      ports/x11/xorg-apps/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 lesi freebsd_committer 2007-07-02 19:24:13 UTC
State Changed
From-To: open->closed

We can just not depend on xsm if rsh is not available so I committed that 
change. Thanks for reporting!