Bug 112932 - [patch] x11/xdm 1.1.4_1 does not inherit environment from login.conf
Summary: [patch] x11/xdm 1.1.4_1 does not inherit environment from login.conf
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-x11 (Nobody)
Depends on:
Reported: 2007-05-24 11:40 UTC by Neil Hoggarth
Modified: 2007-06-07 21:17 UTC (History)
0 users

See Also:

file.diff (792 bytes, patch)
2007-05-24 11:40 UTC, Neil Hoggarth
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Neil Hoggarth 2007-05-24 11:40:09 UTC
I have successfully completed an update from xorg 6.9 to xorg 7.2
following the guidelines in /usr/ports/UPDATING. I have encountered a
regression (also reported by Szalai Andras on the freebsd-x11 mailing
list: http://lists.freebsd.org/pipermail/freebsd-x11/2007-May/004213.html).

The XDM daemon provided by the xorg-clients-6.9 port passed on to the
user's session PATH and other environment settings from the
/etc/login.conf file. The XDM daemon provided by xdm-1.1.4_1 does not.

Fix: I have rebuilt the xdm package with the following patch saved in
/usr/ports/x11/xdm/files/patch-session.c. This restored the expected
behaviour for me. This is based on a patch which used to be applied to
xorg-clients under xorg 6.9:
Comment 1 Edwin Groothuis freebsd_committer 2007-05-24 12:21:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-x11

Over to maintainer
Comment 2 dfilter service freebsd_committer 2007-06-07 20:49:08 UTC
lesi        2007-06-07 19:48:59 UTC

  FreeBSD ports repository

  Modified files:
    x11/xdm              Makefile 
  Added files:
    x11/xdm/files        patch-session.c 
  - Restore inheriting environment from login.conf by restoring patch
    from x11/xorg-clients [1]
  - Restore inheriting SSH_AUTH_SOCK after pam_ssh authentication
    (https://bugs.freedesktop.org/show_bug.cgi?id=11020) [2]
  PR:             ports/112932 [1], ports/113031 [2]
  Obtained from:  X.org git [2]
  Revision  Changes    Path
  1.2       +1 -1      ports/x11/xdm/Makefile
  1.1       +43 -0     ports/x11/xdm/files/patch-session.c (new)
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 lesi freebsd_committer 2007-06-07 21:17:05 UTC
State Changed
From-To: open->closed

Committed. Thanks!