From Squid 2.6, it's url_rewrite_program (redirector) interface have been changed, and www/jesred can't handle new format. Fix: Apply attached patch to www/jesred so that it can handle both old and new format. Patch attached with submission follows: How-To-Repeat: Install www/jesred and www/squid, then configure Squid to use jesred as its url_rewrite_program.
State Changed From-To: open->feedback Awaiting maintainers feedback
On 06/01/07 10:00, Edwin Groothuis wrote: > Please note that PR ports/113212 has just been submitted. Thank you! > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. I don't approve it because it over vendor. I don't think that's a good idea to change software fiunctionality without vendor's approve. -- DSS5-RIPE DSS-RIPN 2:550/5068@fidonet 2:550/5069@fidonet xmpp:dsh@vlink.ru mailto:dsh@vlink.ru http://neva.vlink.ru/~dsh/
> I don't approve it because it over vendor. I don't think that's a good > idea to change software fiunctionality without vendor's approve. Agreed but it's extreme inconvenient that Jesred port is incompatible with Squid port because Jesred is a Squid tool. Anyway I've already reported and sent fix over the author, so please consider applying new patch temporarily which fixes the issue only when WITH_EXTRA_PATCHES knob is set until the author respond. Thanks. -- UEMURA Tetsuya <t_uemura@macome.co.jp>
Responsible Changed From-To: freebsd-ports-bugs->tmclaugh Submitter: Does the patch have any adverse effects on the squid25 or squid30 ports? Maintainer: I understand not wanting to alter vendor code but if the port does not work it should be fixed. The last release of jesred was about 8 years ago while Squid continues to evolve. So long as Squid 2.5 compatibility is not broken it would be helpful to bring this port up to speed with the latest Squid.
Can I get a followup on this PR? As noted above, the patch is required for the port to work correctly with newer version lines of Squid. This is considered a case where patching vendor code is acceptable. Thanks. tom
Hi! On 08/27/07 05:37, Tom McLaughlin wrote: > Can I get a followup on this PR? As noted above, the patch is required > for the port to work correctly with newer version lines of Squid. This > is considered a case where patching vendor code is acceptable. Dear ports commiter, could you apply the patch from the Fix section of ports/113212? I approve it. Thank you! -- DSS5-RIPE DSS-RIPN 2:550/5068@fidonet 2:550/5069@fidonet xmpp:dsh@vlink.ru mailto:dsh@vlink.ru http://neva.vlink.ru/~dsh/
> Does the patch have any adverse effects on the squid25 or squid30 ports? > Maintainer: Jesred made with WITH_EXTRA_PATCHES knob set should work with any version of Squid because it checks input on-the-fly. -- UEMURA Tetsuya <t_uemura@macome.co.jp>
tmclaugh 2007-09-10 15:30:00 UTC FreeBSD ports repository Modified files: www/jesred Makefile Added files: www/jesred/files patch-rewrite.c Log: Fix compatibility with squid26 and squid30. PR: 113212 Submitted by: Tetsuya Uemura Approved by: maintainer Revision Changes Path 1.9 +1 -0 ports/www/jesred/Makefile 1.1 +54 -0 ports/www/jesred/files/patch-rewrite.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Patch committed, thanks.