Bug 113515 - [PATCH]: Some errors in www/lynx-* with devel/ncurses installed
Summary: [PATCH]: Some errors in www/lynx-* with devel/ncurses installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-10 11:20 UTC by Ighighi
Modified: 2007-06-17 09:40 UTC (History)
0 users

See Also:


Attachments
file.diff (483 bytes, patch)
2007-06-10 11:20 UTC, Ighighi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ighighi 2007-06-10 11:20:00 UTC
www/lynx-ssl fails to compile with devel/ncurses installed.
The respective port versions as of this time of writing are:
lynx-ssl-2.8.6_5,1
ncurses-5.6_1

The error message is as follows:
+++++ BEGIN ERROR MESSAGE

cc  -D_BSD_TYPES -D__BSD_VISIBLE -D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=600 -DHAVE_CONFIG_H   -DLOCALEDIR=\"/usr/local/share/locale\"  -I.  -I..  -Ichrtrans  -I./chrtrans  -I..  -I../src  -I../WWW/Library/Implementation    -O -pipe -I/usr/local/include -c ./LYStrings.c
./LYStrings.c: In function `expand_tiname':
./LYStrings.c:953: error: `strnames' undeclared (first use in this function)
./LYStrings.c:953: error: (Each undeclared identifier is reported only once
./LYStrings.c:953: error: for each function it appears in.)
./LYStrings.c:954: error: `strfnames' undeclared (first use in this function)
./LYStrings.c:955: error: `cur_term' undeclared (first use in this function)
*** Error code 1

Stop in /usr/ports/www/lynx-ssl/work/lynx2-8-6/src.
*** Error code 1

Stop in /usr/ports/www/lynx-ssl/work/lynx2-8-6.
*** Error code 1

Stop in /usr/ports/www/lynx-ssl.

+++++ END ERROR MESSAGE

A little inspection revealed to me that the configure mechanism in lynx is
accessing the /usr/local/include/ncurses/* files installed by devel/ncurses
as a side-effect of "-I/usr/local/include", as shown by a diff on the output
of "make configure" when devel/ncurses is available and unavailable, resp.

124c124
< checking for ncurses header in include-path... ncurses/ncurses.h
---
> checking for ncurses header in include-path... curses.h

It is worth noting that www/lynx-current builds perfectly, maybe because their
configure mechanism was corrected.

In my opinion there should be a knob in www/lynx* to allow optional linkage with
devel/ncurses, at least for www/lynx-current since the latter always tries to
use the version in ports first, unlike www/lynx and www/lynx-ssl, thus making
devel/ncurses a dependency.

Fix: The attached patch deletes the following line in /usr/ports/www/lynx-ssl/work/lynx2-8-6/config.hin

#undef HAVE_NCURSES_NCURSES_H  /* defined if we include <ncurses/ncurses.h> */


Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2007-06-10 11:20:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rafan

Over to maintainer
Comment 2 dfilter service freebsd_committer 2007-06-17 09:34:33 UTC
rafan       2007-06-17 08:34:28 UTC

  FreeBSD ports repository

  Modified files:
    www/lynx             Makefile 
  Log:
  - Force lynx to pick up ncurses from base. This fixes build when
    1) devel/ncurses is installed, and 2) use OpenSSL from ports.
    In that case, lynx picks up ncurses/ncurses.h which is from ports
    and somehow it does not include term.h
  
  PR:           ports/113515
  Reported by:  Ighighi <ighighi at gmail.com>
  Approved by:  Jason Harris <jharris at widomaker.com> (maintainer)
  
  Revision  Changes    Path
  1.120     +1 -1      ports/www/lynx/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Rong-En Fan freebsd_committer 2007-06-17 09:34:41 UTC
State Changed
From-To: open->closed

Committed with another approach. Thanks.