Bug 114792 - [patch] bad dependencies in audio/tuxguitar
Summary: [patch] bad dependencies in audio/tuxguitar
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Herve Quiroz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-21 11:50 UTC by Olivier
Modified: 2007-07-28 01:40 UTC (History)
0 users

See Also:

Attachments
file.diff (408 bytes, patch)
2007-07-21 11:50 UTC, Olivier 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier 2007-07-21 11:50:01 UTC 
audio/tuxguitar not only BUILD_DEPENDS on x11-toolkits/swt and devel/itext, it RUN_DEPENDS on these too.

Fix: I tested, it needs swt and itext in both BUILD and RUN.
How-To-Repeat: # cd /usr/ports/audio/tuxguitar/
# make install clean
# pkg_delete swt-3.2.2_1
% tuxguitar
Exception in thread "main" java.lang.NoClassDefFoundError: org/eclipse/swt/widgets/Layout
# pkg_delete itext-2.0.4,1
% tuxguitar
Exception in thread "main" java.lang.NoClassDefFoundError: com/lowagie/text/BadElementException
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-07-21 11:50:10 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Pietro Cerutti 2007-07-23 00:07:45 UTC 
This is a multi-part message in MIME format.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2007-07-23 10:45:40 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 4 Pietro Cerutti 2007-07-25 12:53:42 UTC 
Please submit the following patch:

--- Makefile.orig       Wed Jul 25 13:49:47 2007
+++ Makefile    Wed Jul 25 13:50:20 2007
@@ -7,7 +7,7 @@

 PORTNAME=      tuxguitar
 PORTVERSION=   0.9.1
-PORTREVISION=  1
+PORTREVISION=  2
 CATEGORIES=    audio java
 MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE_EXTENDED}
 MASTER_SITE_SUBDIR=${PORTNAME}
@@ -17,6 +17,9 @@
 COMMENT=       A Multitrack tablature editor and player

 BUILD_DEPENDS= ${JAVALIBDIR}/swt.jar:${PORTSDIR}/x11-toolkits/swt \
+               ${JAVALIBDIR}/itext.jar:${PORTSDIR}/devel/itext
+
+RUN_DEPENDS=   ${JAVALIBDIR}/swt.jar:${PORTSDIR}/x11-toolkits/swt \
                ${JAVALIBDIR}/itext.jar:${PORTSDIR}/devel/itext

 WRKSRC=                ${WRKDIR}/TuxGuitar-0.9.1-src

Thank you.
-- 
Pietro Cerutti

PGP Public Key:
http://gahr.ch/pgp
Comment 5 Herve Quiroz freebsd_committer freebsd_triage 2007-07-28 00:56:22 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->hq

I'll handle this.
Comment 6 dfilter service freebsd_committer freebsd_triage 2007-07-28 01:32:40 UTC 
hq          2007-07-28 00:32:35 UTC

  FreeBSD ports repository

  Modified files:
    audio/tuxguitar      Makefile 
  Log:
  Add missing x11-toolkits/swt and devel/itext to RUN_DEPENDS
  
  PR:             114792
  Submitted by:   Olivier Smedts <olivier@gid0.org>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.4       +4 -1      ports/audio/tuxguitar/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Herve Quiroz freebsd_committer freebsd_triage 2007-07-28 01:32:42 UTC 
State Changed
From-To: open->closed

Patch commited. Thanks for your contribution.