Bug 115771 - [PATCH] sysutils/gnome-volume-manager: inifite loop on startup
Summary: [PATCH] sysutils/gnome-volume-manager: inifite loop on startup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-24 00:10 UTC by mwisnicki+freebsd
Modified: 2007-08-26 01:40 UTC (History)
1 user (show)

See Also:

Attachments
gnome-volume-manager-2.17.0_5.patch (1.39 KB, patch)
2007-08-24 00:10 UTC, mwisnicki+freebsd 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mwisnicki+freebsd 2007-08-24 00:10:01 UTC 
Integer underflow will cause "while (!local && --len >= 0)" to be always true
if no local entry was found in the loop.

I have also changed wtmp to utmp as we are looking for current users.

With this patch g-v-m no longer hangs in my Xvnc-based jail.

Port maintainer (gnome@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-08-24 00:10:09 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2007-08-26 01:39:41 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2007-08-26 01:39:44 UTC 
marcus      2007-08-26 00:39:38 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/gnome-volume-manager Makefile 
    sysutils/gnome-volume-manager/files patch-src_manager.c 
  Log:
  * Read from utmp rather than wtmp since we are looking for current users
  * Fix an integer underflow which could result in an infinite loop on startup
  
  PR:             115771
  Submitted by:   Marcin Wisnicki <mwisnicki+freebsd@gmail.com>
  
  Revision  Changes    Path
  1.7       +1 -1      ports/sysutils/gnome-volume-manager/Makefile
  1.4       +2 -2      ports/sysutils/gnome-volume-manager/files/patch-src_manager.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"