Bug 116329 - www/apache20 rc-script doesn't always source %%PREFIX%%/sbin/envvars when needed
Summary: www/apache20 rc-script doesn't always source %%PREFIX%%/sbin/envvars when needed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Clement Laforet
Depends on:
Reported: 2007-09-13 12:00 UTC by Ruud Althuizen
Modified: 2007-09-18 21:10 UTC (History)
0 users

See Also:

file.diff (857 bytes, patch)
2007-09-13 12:00 UTC, Ruud Althuizen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ruud Althuizen 2007-09-13 12:00:14 UTC
When you add *.env files to /usr/local/etc/apache2/envvars.d/ they only
get sourced after start_cmd(). But apache2_checkconfig() also needs those
includes. So I moved the lines.

Fix: Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2007-09-13 12:33:46 UTC
Responsible Changed
From-To: freebsd-bugs->clement

Make this a ports PR and assign.
Comment 2 Clement Laforet freebsd_committer 2007-09-18 20:19:35 UTC
State Changed
From-To: open->closed

Good catch, thanks! 
I'll backport it to www/apache22 too.
Comment 3 dfilter service freebsd_committer 2007-09-18 21:03:22 UTC
clement     2007-09-18 20:03:15 UTC

  FreeBSD ports repository

  Modified files:
    .                    UPDATING 
    www/apache22         Makefile 
    www/apache22/files   apache22.sh.in 
  Added files:
    www/apache22         Makefile.options 
  - Add experimental support of OPTIONS.
    From UPDATING:
    By popular request, OPTIONS support has been added. When actived
    (default), these knobs are ignored:
            * WITH_CUSTOM_<CATEGORY>
            * WITH_MODULES
            * WITHOUT_MODULES
    However, you can disable OPTIONS by defining WITHOUT_APACHE_OPTIONS.
  - move envvars support to the beginning of apache22_checkconfig() to be
    sure we're using envvars during configtest [1]
  PR:             ports/116329 [1]
  Submitted by:   Ruud Althuizen <ruud@il.fontys.nl> [1]
  Revision  Changes    Path
  1.543     +15 -1     ports/UPDATING
  1.210     +11 -0     ports/www/apache22/Makefile
  1.1       +75 -0     ports/www/apache22/Makefile.options (new)
  1.5       +6 -6      ports/www/apache22/files/apache22.sh.in
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"