Bug 116627 - [patch] www/apache22: completely shut up rc.d script when no profiles are enabled
Summary: [patch] www/apache22: completely shut up rc.d script when no profiles are ena...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Clement Laforet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-25 08:10 UTC by Eygene Ryabinkin
Modified: 2008-09-02 08:41 UTC (History)
1 user (show)

See Also:


Attachments
apache22.sh.in.respect-enable.patch (843 bytes, patch)
2007-09-25 08:10 UTC, Eygene Ryabinkin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eygene Ryabinkin 2007-09-25 08:10:01 UTC
If one has a number of Apache profiles, but has apache22_enable set
to NO, rc.d script still prints the names of the profiles (but, of
cource, does no further actions).  This is a bit annoying as it can
provoke the thoughts that something gone terribly wrong.

Fix: The following patch fixes the situation.  Furthermore, it checks
the apache22*_enable values to be 'yes', 'no' or 'none' and issues
warning if some variable has the other value.
How-To-Repeat: 
Add a couple of Apache profiles, do not set individual values
for apache22_<profile>_enable and set apache22_enable to NO.
Run /usr/local/etc/rc.d/apache22 start and see the profile
banners.

The same effect can be achieved if not all apache22_<profile>_enable
are set to 'yes': rc.d script will still output names of all profiles.
Comment 1 Edwin Groothuis freebsd_committer 2007-09-25 08:10:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->clement

Over to maintainer
Comment 2 Clement Laforet freebsd_committer 2008-09-02 08:41:13 UTC
State Changed
From-To: open->closed

Patch committed, thanks!