Bug 117320 - [patch] devel/arm-elf-gcc295 Static declaration follows non-static declaration
Summary: [patch] devel/arm-elf-gcc295 Static declaration follows non-static declaration
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-19 13:40 UTC by Pietro Cerutti
Modified: 2007-11-06 10:30 UTC (History)
0 users

See Also:

Attachments
arm-elf-gcc295-patch.txt (3.50 KB, text/plain)
2007-11-03 16:46 UTC, jflemer 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pietro Cerutti 2007-10-19 13:40:02 UTC 
The patch file provided in files/libiberty-strsignal.c should remove the "static" modifier to the definition of sys_nsig, since we don't declare it as static in signal.h:
extern __const int sys_nsig;

Fix: patch to patch file files/libiberty-strsignal.c is:



#ifdef NSIG
 -static int sys_nsig = NSIG;
-+static __const int sys_nsig = NSIG;
++__const int sys_nsig = NSIG;
  #else
  #ifdef _NSIG
  static int sys_nsig = _NSIG;--KTGzi6H5GeEut09n3x0vaWBD5UsgqM2sGYDflxbgSGIpVzTG
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- libiberty-strsignal.c.orig  2007-10-19 14:30:28.000000000 +0200
+++ libiberty-strsignal.c       2007-10-19 14:30:18.000000000 +0200
@@ -5,7 +5,7 @@
How-To-Repeat: cd /usr/ports/devel/arm-elf-gcc-295 && make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-10-19 13:43:16 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 jflemer 2007-11-03 16:46:35 UTC 
Maintainer patch attached for ports/117320 and ports/117322.

#
# - Fix compile with GCC 4.2
#
# PRs:                 ports/117320, ports/117322
# Based on patches by: Pietro Cerutti <gahr@gahr.ch>
# Submitted by:        James Flemer <jflemer@alum.rpi.edu>
#

Tested on FreeBSD 6.2 w/ GCC 4.2 and with GCC 3.4.  Not tested on 
FreeBSD 7, though it was marked broken on 7 due to GCC 4.2 so I believe 
this should fix it there as well.

NOTE to committer: This includes removal of two files, and addition of 
two files.
   Remove: devel/arm-elf-gcc295/files/libiberty-strerror.c
   Remove: devel/arm-elf-gcc295/files/libiberty-strsignal.c
   Add:    devel/arm-elf-gcc295/files/patch-gcc::config::arm::arm.c
   Add:    devel/arm-elf-gcc295/files/patch-libiberty::strerror.c
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2007-11-04 22:39:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

Eat
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-11-06 10:23:08 UTC 
miwi        2007-11-06 10:23:03 UTC

  FreeBSD ports repository

  Modified files:
    devel/arm-elf-gcc295 Makefile 
  Added files:
    devel/arm-elf-gcc295/files patch-gcc-config-arm_arm.c 
                               patch-libiberty_strerror.c 
  Removed files:
    devel/arm-elf-gcc295/files libiberty-strerror.c 
                               libiberty-strsignal.c 
  Log:
  - Fix build with gcc 4.2
  
  PR:             117320
                  117322
  Submitted by:   Pietro Cerutti <gahr@gahr.ch>
                  James E. Flemer <jflemer@alum.rpi.edu> (maintainer)
  Approved by:    portmgr (pav)
  
  Revision  Changes    Path
  1.25      +1 -6      ports/devel/arm-elf-gcc295/Makefile
  1.2       +0 -14     ports/devel/arm-elf-gcc295/files/libiberty-strerror.c (dead)
  1.2       +0 -11     ports/devel/arm-elf-gcc295/files/libiberty-strsignal.c (dead)
  1.1       +20 -0     ports/devel/arm-elf-gcc295/files/patch-gcc-config-arm_arm.c (new)
  1.1       +14 -0     ports/devel/arm-elf-gcc295/files/patch-libiberty_strerror.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2007-11-06 10:23:17 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!