Bug 117874 - [patch] graphics/ffff: unbreak building with gcc-4.2
Summary: [patch] graphics/ffff: unbreak building with gcc-4.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-06 19:20 UTC by Boris Samorodov
Modified: 2008-05-31 23:10 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Samorodov freebsd_committer freebsd_triage 2007-11-06 19:20:00 UTC 
	The port marked as broken for gcc-4.2.

Fix: The idea is taken from the Sourceforge Jackit-devel mailing list.
	. unbreak building with gcc-4.2 (add compile options -msse -msse2 -m3dnow);
	. bump PORTREVISION.



WBR
-- 
bsam--72ZdgFc31KRZT3Ij0JXJWwgdhv0NL2DNajjwdnUdTlxBUh3o
Content-Type: text/plain; name="ffff.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="ffff.diff"

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/graphics/ffff/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile	4 Oct 2007 08:50:50 -0000	1.3
+++ Makefile	6 Nov 2007 19:02:34 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	ffff
 PORTVERSION=	323
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE_EXTENDED}
 MASTER_SITE_SUBDIR=	${PORTNAME}
@@ -29,7 +29,7 @@
 		extensions vpext
 
 CXXFLAGS+=	-I${X11BASE}/include -I${X11BASE}/include/GL ${PTHREAD_CFLAGS} \
-		-D__linux__
+		-D__linux__ -msse -msse2 -m3dnow
 LDFLAGS+=	-L${X11BASE}/lib ${PTHREAD_LIBS} -lglut -lGL -lXext -lX11 -lXmu \
 		 -lGLU -lm
 
@@ -47,10 +47,4 @@
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
 
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} >= 700042
-BROKEN=		Does not compile with GCC 4.2
-.endif
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-11-06 19:20:09 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->bsam

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2007-11-06 19:20:12 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2008-05-14 14:21:52 UTC 
State Changed
From-To: feedback->open

Maintainer timeout reached
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-05-31 23:07:18 UTC 
miwi        2008-05-31 22:07:14 UTC

  FreeBSD ports repository

  Modified files:
    graphics/ffff        Makefile 
  Log:
  - Unbreak
  - Fix build with gcc 4.2
  
  PR:             117874
  Submitted by:   bsam
  Approved by:    maintainer timeout
  
  Revision  Changes    Path
  1.7       +2 -8      ports/graphics/ffff/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2008-05-31 23:07:26 UTC 
State Changed
From-To: open->closed

Committed. Thanks!