Bug 118185 - [patch] games/adonthell unbreak fix build w/ GCC 4.2 + upgrade to python25
Summary: [patch] games/adonthell unbreak fix build w/ GCC 4.2 + upgrade to python25
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-21 18:20 UTC by Pietro Cerutti
Modified: 2007-11-22 10:50 UTC (History)
0 users

See Also:

Attachments
_adonthell.diff (5.82 KB, patch)
2007-11-21 18:20 UTC, Pietro Cerutti 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pietro Cerutti 2007-11-21 18:20:01 UTC 

- fixed an "extra qualification on member" error
- got rid of a few string -> char * conversion warnings
- upgraded USE_PYTHON from "-2.4" to "-2.5"
- removed useless USE_GMAKE flag from Makefile

How-To-Repeat: 

cd /usr/ports/games/adonthell && make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-11-21 18:20:11 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Pietro Cerutti 2007-11-21 21:25:21 UTC 
Indeed, USE_GMAKE was not useless...
Here's the latest version of the patch:

http://www.gahr.ch/FreeBSD/patches/118185_adonthell.diff

-- 
Pietro Cerutti

PGP Public Key:
http://gahr.ch/pgp
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2007-11-22 08:37:18 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-11-22 10:46:05 UTC 
miwi        2007-11-22 08:37:10 UTC

  FreeBSD ports repository

  Modified files:
    games/adonthell      Makefile 
  Added files:
    games/adonthell/files patch-src_dialog.cc 
                          patch-src_drawing_area.h 
                          patch-src_music.c patch-src_prefs.cc 
                          patch-src_py_callback.cc 
  Log:
  - Fix build with gcc 4.2
  
  PR:             118185
  Submitted by:   Pietro Cerutti <gahr@gahr.ch>
  Approved by:    portmgr (erwin)
  
  Revision  Changes    Path
  1.24      +2 -6      ports/games/adonthell/Makefile
  1.1       +41 -0     ports/games/adonthell/files/patch-src_dialog.cc (new)
  1.1       +11 -0     ports/games/adonthell/files/patch-src_drawing_area.h (new)
  1.1       +20 -0     ports/games/adonthell/files/patch-src_music.c (new)
  1.1       +11 -0     ports/games/adonthell/files/patch-src_prefs.cc (new)
  1.1       +40 -0     ports/games/adonthell/files/patch-src_py_callback.cc (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"