Bug 118936 - sysutils/hal fails to compile on FreeBSD v6.0
Summary: sysutils/hal fails to compile on FreeBSD v6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-21 18:50 UTC by alex
Modified: 2007-12-22 22:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description alex 2007-12-21 18:50:00 UTC
Attempting to build sysutils/hal under FreeBSD 6.0 produces the following error.
#if guard block at line 62 doesn't seem to have the correct version number.

cc -O2 -fno-strict-aliasing -pipe -Wall -Wchar-subscripts -Wmissing-declarations -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -o .libs/hald-probe-volume hald_probe_volume-freebsd_dvd_rw_utils.o hald_probe_volume-probe-volume.o  -L/usr/local/lib /usr/local/lib/libglib-2.0.so -licui18n /usr/local/lib/libpcre.so -lvolume_id ../../../hald/freebsd/libprobe/.libs/libhald_freebsd_probe.so /usr/ports/sysutils/hal/work/hal-0.5.8.20071216/libhal/.libs/libhal.so /usr/local/lib/libdbus-1.so -pthread /usr/local/lib/libintl.so /usr/local/lib/libiconv.so -lcam  -Wl,--rpath -Wl,/usr/local/lib
hald_probe_volume-probe-volume.o(.text+0x592): In function `main':
: undefined reference to `isonum_731'
gmake[5]: *** [hald-probe-volume] Error 1

Fix: 

Change hal-0.5.8.20071216/hald/freebsd/probing/probe-volume.c, 
line 62 guard for ISO number definition should be:

#if __FreeBSD_version < 600101

instead of 

#if __FreeBSD_version < 600000


(By my reckoning, the new ISO number definitions got added to iso.h between 600100 and 600101.)
How-To-Repeat: in FreeBSD version 600034,

$ cd /usr/ports/sysutils/hal
$ make
Comment 1 Edwin Groothuis freebsd_committer 2007-12-21 18:50:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2007-12-22 21:58:20 UTC
marcus      2007-12-22 21:58:13 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/hal         Makefile distinfo 
  Log:
  Update to 20071222 which allows hal to build on 6.0.
  
  PR:             118936
  Submitted by:   Alex Stangl <alex@stangl.us>
  
  Revision  Changes    Path
  1.29      +1 -1      ports/sysutils/hal/Makefile
  1.15      +3 -3      ports/sysutils/hal/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Joe Marcus Clarke freebsd_committer 2007-12-22 21:58:22 UTC
State Changed
From-To: open->closed

Fixed in snapshot 20071222.