Bug 119464 - [patch] [request] Add 'sorted' option to etc/periodic/security/security.functions
Summary: [patch] [request] Add 'sorted' option to etc/periodic/security/security.funct...
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-01-08 19:30 UTC by Esa Karkkainen
Modified: 2022-10-17 16:55 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (939 bytes, patch)
2008-01-08 19:30 UTC, Esa Karkkainen 		no flags Details | Diff
Updated unified diff, against 12.3-RELEASE, version 322868 (931 bytes, patch)
2022-10-17 16:37 UTC, Esa Karkkainen 		no flags Details | Diff
Patch to 100.chksetuid (449 bytes, patch)
2022-10-17 16:53 UTC, Esa Karkkainen 		no flags Details | Diff
Patch add etc/defaults/periodic.conf (334 bytes, patch)
2022-10-17 16:55 UTC, Esa Karkkainen 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Esa Karkkainen 2008-01-08 19:30:01 UTC 
Add option to check_diff function which changes "setuid diffs" from

---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---
Amnesiac setuid diffs:
--- /var/log/setuid.today       Mon May  8 03:01:22 2006
+++ /tmp/security.DSozUbFb      Tue Jun 13 03:01:22 2006
@@ -33,7 +33,7 @@
 612402 -r-sr-xr-x  2 root  wheel     5828 May  7 13:25:03 2006 /usr/bin/yppasswd
 141367 -r-sr-xr-x  1 root  wheel     3400 May  7 13:14:41 2006 /usr/libexec/pt_chown
 141330 -r-xr-sr-x  1 root  smmsp   582752 May  7 13:28:03 2006 /usr/libexec/sendmail/sendmail
-730599 -rwsr-xr-x  1 root  wheel   278660 Oct 28 18:09:06 2005 /usr/local/bin/screen
+730291 -rwsr-xr-x  1 root  wheel   285580 Jun 12 20:56:14 2006 /usr/local/bin/screen
 730672 ---s--x--x  2 root  wheel    89020 Jan 27 01:52:14 2006 /usr/local/bin/sudo
 730672 ---s--x--x  2 root  wheel    89020 Jan 27 01:52:14 2006 /usr/local/bin/sudoedit
 329886 -r-sr-sr-x  1 root  authpf   14724 May  7 13:26:08 2006 /usr/sbin/authpf
---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---

to

---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---
Amnesiac setuid diffs:
+++ /tmp/security.DSozUbFb      Tue Jun 13 03:01:22 2006
--- /var/log/setuid.today       Mon May  8 03:01:22 2006
+730291 -rwsr-xr-x  1 root  wheel   285580 Jun 12 20:56:14 2006 /usr/local/bin/screen
-730599 -rwsr-xr-x  1 root  wheel   278660 Oct 28 18:09:06 2005 /usr/local/bin/screen
---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---

IMHO the latter output is easier to comprehend.

Patch does not change traditional FreeBSD behaviour (POLA).

Admin must add "sorted" as first argument to check_diff funtion call in
"/etc/periodic/security/100.chksetuid" file.

How-To-Repeat: N/A
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:59:17 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:35:56 UTC 
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
Comment 3 Esa Karkkainen 2022-10-17 16:37:10 UTC 
Created attachment 237415 [details]
Updated unified diff, against 12.3-RELEASE, version 322868

This is an updated patch, against somewhat newer version.
Comment 4 Esa Karkkainen 2022-10-17 16:53:45 UTC 
Created attachment 237416 [details]
Patch to 100.chksetuid

Patch to 100.chksetuid
Comment 5 Esa Karkkainen 2022-10-17 16:55:27 UTC 
Created attachment 237417 [details]
Patch add etc/defaults/periodic.conf

Patch etc/defaults/periodic.conf, with the default value "setuid".