vidcontrol -i mode miss the mode 0x1ff=M_VESA_MODE_MAX in listing due off-by-one bug The M_VESA_MODE_MAX is latest valid mode - not the first invalid How-To-Repeat: use vidcontrol -i mode on hardware which has 0x1ff mode - it will not be listed
Author: eadler Date: Sat May 11 13:32:38 2013 New Revision: 250509 URL: http://svnweb.freebsd.org/changeset/base/250509 Log: The M_VESA_MODE_MAX is latest valid mode - not the first invalid. Permit its use in vidcontrol -i PR: bin/119483 Submitted by: Dan Lukes <dan@obluda.cz> Arrival-Date: Wed Jan 09 10:30:01 UTC 2008 Reviewed by: ed MFC after: 3 days Modified: head/usr.sbin/vidcontrol/vidcontrol.c Modified: head/usr.sbin/vidcontrol/vidcontrol.c ============================================================================== --- head/usr.sbin/vidcontrol/vidcontrol.c Sat May 11 13:21:31 2013 (r250508) +++ head/usr.sbin/vidcontrol/vidcontrol.c Sat May 11 13:32:38 2013 (r250509) @@ -959,7 +959,7 @@ show_mode_info(void) printf("---------------------------------------" "---------------------------------------\n"); - for (mode = 0; mode < M_VESA_MODE_MAX; ++mode) { + for (mode = 0; mode <= M_VESA_MODE_MAX; ++mode) { _info.vi_mode = mode; if (ioctl(0, CONS_MODEINFO, &_info)) continue; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Author: eadler Date: Fri May 17 00:40:46 2013 New Revision: 250729 URL: http://svnweb.freebsd.org/changeset/base/250729 Log: MFC r250509: The M_VESA_MODE_MAX is latest valid mode - not the first invalid. Permit its use in vidcontrol -i PR: bin/119483 Modified: stable/9/usr.sbin/vidcontrol/vidcontrol.c Directory Properties: stable/9/usr.sbin/vidcontrol/ (props changed) Modified: stable/9/usr.sbin/vidcontrol/vidcontrol.c ============================================================================== --- stable/9/usr.sbin/vidcontrol/vidcontrol.c Fri May 17 00:26:56 2013 (r250728) +++ stable/9/usr.sbin/vidcontrol/vidcontrol.c Fri May 17 00:40:46 2013 (r250729) @@ -961,7 +961,7 @@ show_mode_info(void) printf("---------------------------------------" "---------------------------------------\n"); - for (mode = 0; mode < M_VESA_MODE_MAX; ++mode) { + for (mode = 0; mode <= M_VESA_MODE_MAX; ++mode) { _info.vi_mode = mode; if (ioctl(0, CONS_MODEINFO, &_info)) continue; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Author: eadler Date: Fri May 17 00:40:48 2013 New Revision: 250730 URL: http://svnweb.freebsd.org/changeset/base/250730 Log: MFC r250509: The M_VESA_MODE_MAX is latest valid mode - not the first invalid. Permit its use in vidcontrol -i PR: bin/119483 Modified: stable/8/usr.sbin/vidcontrol/vidcontrol.c Modified: stable/8/usr.sbin/vidcontrol/vidcontrol.c ============================================================================== --- stable/8/usr.sbin/vidcontrol/vidcontrol.c Fri May 17 00:40:46 2013 (r250729) +++ stable/8/usr.sbin/vidcontrol/vidcontrol.c Fri May 17 00:40:48 2013 (r250730) @@ -961,7 +961,7 @@ show_mode_info(void) printf("---------------------------------------" "---------------------------------------\n"); - for (mode = 0; mode < M_VESA_MODE_MAX; ++mode) { + for (mode = 0; mode <= M_VESA_MODE_MAX; ++mode) { _info.vi_mode = mode; if (ioctl(0, CONS_MODEINFO, &_info)) continue; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Already commited, never closed for unknown reason.