Bug 119655 - security/stunnel start script does not honor stunnel_config on boot
Summary: security/stunnel start script does not honor stunnel_config on boot
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Peter Pentchev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-14 10:50 UTC by Jason DiCioccio
Modified: 2008-01-24 00:44 UTC (History)
0 users

See Also:


Attachments
file.diff (3.31 KB, patch)
2008-01-14 10:50 UTC, Jason DiCioccio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason DiCioccio 2008-01-14 10:50:01 UTC
	
It's an odd issue.  When using the stunnel start script that comes with the
port, executing the script manually (rc.d/stunnel.sh start) will correctly start
the service.  However, this is not the case on boot.  It fails to grab the
stunnel_config line from rc.conf and instead uses the hardcoded one in the
script.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-01-14 21:49:46 UTC
Responsible Changed
From-To: freebsd-ports-bugs->roam

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-01-24 00:36:52 UTC
roam        2008-01-24 00:36:43 UTC

  FreeBSD ports repository

  Modified files:
    security/stunnel     Makefile distinfo pkg-plist 
    security/stunnel/files stunnel.sh 
  Removed files:
    security/stunnel/files patch-src::prototypes.h 
                           patch-src::stunnel.c 
                           patch-tools::stunnel.init.in 
  Log:
  Update the stunnel port to version 4.22b2 to fix inetd mode logging[1].
  
  While I'm here, pick up various changes from PR's:
  - convert the startup script to the new style[2], but do not yet enable
    USE_RC_SUBR; a repo-copy of stunnel.sh to stunnel.in should be done first
  - use ETCDIR instead of PREFIX/etc/stunnel everywhere[3]
  - wave a magic wand over the startup script generation process to mimic
    the changes that will be done by USE_RC_SUBR after the repo-copy
  
  Prompted by:    Damian Wiest <dwiest@vailsys.com> and
                  Luis Rodrigo Gallardo Cruz <rodrigo@nul-unu.com> on
                  the stunnel-users mailing list [1]
  PR:             119655 [2] - only the changes to the startup script
                  116773 [3] - only the ETCDIR part
  Submitted by:   Jason DiCioccio <jd@ods.org> [2],
                  Alexander Logvinov <ports@logvinov.com> [3]
  
  Revision  Changes    Path
  1.83      +7 -6      ports/security/stunnel/Makefile
  1.45      +3 -3      ports/security/stunnel/distinfo
  1.2       +0 -12     ports/security/stunnel/files/patch-src::prototypes.h (dead)
  1.2       +0 -92     ports/security/stunnel/files/patch-src::stunnel.c (dead)
  1.3       +0 -11     ports/security/stunnel/files/patch-tools::stunnel.init.in (dead)
  1.8       +9 -9      ports/security/stunnel/files/stunnel.sh
  1.14      +2 -2      ports/security/stunnel/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Peter Pentchev freebsd_committer freebsd_triage 2008-01-24 00:42:27 UTC
State Changed
From-To: open->closed

Your changes to the startup script were included in the update of 
stunnel to version 4.22b2 that I just committed; the update was done 
a bit differently because I'm waiting for a repository copy of stunnel.sh 
to stunnel.in to finish the USE_RC_SUBR=stunnel transition. 

Many thanks for your work and your patch!