Bug 121772 - [patch] audio/musicpd : rc script not run at boot
Summary: [patch] audio/musicpd : rc script not run at boot
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-17 01:40 UTC by Justin Stallard
Modified: 2008-04-04 10:30 UTC (History)
0 users

See Also:

Attachments
file.diff (357 bytes, patch)
2008-03-17 01:40 UTC, Justin Stallard 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Stallard 2008-03-17 01:40:00 UTC 
The rc script included with the port, installed to /usr/local/etc/rc.d/musicpd, 
is not run at boot, despite placing the appropriate entry in /etc/rc.conf. 
Running the script manually, however, does start the service.

Fix: Patch attached.


Patch attached with submission follows:
How-To-Repeat: Install the audio/musicpd port
add 'musicpd_enable="YES"' to /etc/rc.conf
reboot
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-03-17 01:40:07 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Rong-En Fan freebsd_committer freebsd_triage 2008-03-17 01:53:54 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->rafan

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2008-04-04 07:20:38 UTC 
rafan       2008-04-04 06:20:33 UTC

  FreeBSD ports repository

  Modified files:
    audio/musicpd        Makefile 
    audio/musicpd/files  musicpd.sh.in 
  Log:
  - rc script was not executed at boot due to empty REQUIRE and BEFORE. Fix
    that by using REQUIRE: LOGIN per Porter's Handbook.
  - While I'm here, change default variable assignment to the way suggested by
    Porter's Handbook.
  - Bump PORTREVISION
  
  PR:             ports/121772 (based on)
  Submitted by:   Justin Stallard <justin at isis.poly.edu>
  Approved by:    maintainer timeout (2 weeks)
  
  Revision  Changes    Path
  1.33      +1 -0      ports/audio/musicpd/Makefile
  1.2       +4 -6      ports/audio/musicpd/files/musicpd.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Rong-En Fan freebsd_committer freebsd_triage 2008-04-04 07:20:41 UTC 
State Changed
From-To: feedback->closed

Committed with changes. Thanks!
Comment 5 Angelo Turetta 2008-04-04 10:11:55 UTC 
The real missing dependency is not on LOGIN.

When the port is built, if the avahi-app port is installed in the build 
machine, a stealth RUN_DEPEND on avahi-app is linked in mpd: I mean, the 
  binary fails to start if avahi-daemon is not running, but avahi-app is 
not even listed as a dependency for the package.

The startup problem arises because avahi-daemon installs an old-style 
startup script (ending in .sh), so it is normally started after musicpd. 
The correct solution would be to convert avahi-daemon to rcNG, and make 
musicpd depend on avahi-daemon at both the startup script and the pkg 
levels.

I'll see if I can implement this in a patch.

Angelo.