Bug 122993 - setup.sh for audio/mpdscribble
Summary: setup.sh for audio/mpdscribble
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-22 19:40 UTC by Sokolov Alexey
Modified: 2008-06-01 13:40 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sokolov Alexey 2008-04-22 19:40:01 UTC

Fix: ### BEGIN PATCH 



mkdir -p $CONF_DIR
 mkdir -p $CACHE_DIR
@@ -35,7 +35,7 @@
 echo -n "Please enter your audioscrobbler username: "
 read -e USERNAME
 echo -n "and password: "
-read -s -e PASSWORD
+read -e PASSWORD

 echo "username = $USERNAME" > $LOGIN
 chmod 600 $LOGIN

### END PATCH

Recommendation:
Include in 'pkg-plist' script 'setup.sh' as mpdscribblesetup.--kn0T0SnkBsmThLdmzR2gNiOxZFCXn6Vxc4z2zYCdILRvufVt
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- setup.sh.orig       2008-04-22 19:46:57.000000000 +0000
+++ setup.sh    2008-04-22 19:47:00.000000000 +0000
@@ -26,7 +26,7 @@
 echo
 echo "press ctrl-c to cancel if this is not intended."
 echo "continue..."
-read -s
+read
How-To-Repeat: cd /usr/ports/audio/mpdscribble/work/mpdscribble-0.2.12/
./setup.sh
Comment 1 Rong-En Fan freebsd_committer 2008-06-01 12:56:46 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rafan

I'll take it.
Comment 2 Rong-En Fan freebsd_committer 2008-06-01 13:34:14 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer 2008-06-01 13:34:15 UTC
rafan       2008-06-01 12:34:11 UTC

  FreeBSD ports repository

  Modified files:
    audio/mpdscribble    Makefile 
  Added files:
    audio/mpdscribble/files patch-setup.sh 
  Log:
  - Do not assume /bin/sh is bash in setup.sh
  - Install setup.sh as mpdscribble-setup which is required at runtime
  - Bump PORTREVISION
  
  PR:             ports/122993
  Submitted by:   Sokolov Alexey <sokolov at truebsd.org>
  
  Revision  Changes    Path
  1.8       +5 -1      ports/audio/mpdscribble/Makefile
  1.1       +20 -0     ports/audio/mpdscribble/files/patch-setup.sh (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"