update to 1.4.0.56102 Since this is a major release update, there are many changes to the FreeBSD patches. All patch-* are deleted, and new patches are in this patch. Maybe it is better to use a shar ball rather than a diff patch?
Responsible Changed From-To: freebsd-ports-bugs->lofi Over to maintainer (via the GNATS Auto Assign Tool)
Responsible Changed From-To: lofi->freebsd-ports-bugs Maintainer was reset.
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
> Synopsis: [patch] audio/last.fm: update to 1.4.0.56102 > > http://www.freebsd.org/cgi/query-pr.cgi?pr=124177 Umm, is there a reson to have portaudio.h bundled with the port? We have both version 18 and 19 of portaudio in the ports collection, won't it be easier to make this port use on of them instead of (I assume, not looked into sources yet) patching and building bundled portaudio? Also, please remove trivial patches and use REINPLACE_CMD instead. At least s|portaudio.h|pa_audio.h| should be done that way. Finally, aren't you interested in maintaining this port? -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
State Changed From-To: open->feedback
Dmitry Marakasov <amdmi3@amdmi3.ru> writes: >> Synopsis: [patch] audio/last.fm: update to 1.4.0.56102 >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=124177 > Umm, is there a reson to have portaudio.h bundled with the port? We have > both version 18 and 19 of portaudio in the ports collection, won't it be > easier to make this port use on of them instead of (I assume, not looked > into sources yet) patching and building bundled portaudio? I've not tested with the version 19 of portaudio. For version 18, the port won't compile. I'll give it a try with the version 19 and see if it is OK. > > Also, please remove trivial patches and use REINPLACE_CMD instead. At > least s|portaudio.h|pa_audio.h| should be done that way. OK. > > Finally, aren't you interested in maintaining this port? It is OK. Recently I've been doing some qt4 stuff. This won't add much effort I hope. -- Denise H. G. <darcsis AT gmail DOT com>
* Denise H. G. (darcsis@gmail.com) wrote: > > Umm, is there a reson to have portaudio.h bundled with the port? We have > > both version 18 and 19 of portaudio in the ports collection, won't it be > > easier to make this port use on of them instead of (I assume, not looked > > into sources yet) patching and building bundled portaudio? > I've not tested with the version 19 of portaudio. For version 18, the > port won't compile. I'll give it a try with the version 19 and see if it > is OK. > > Also, please remove trivial patches and use REINPLACE_CMD instead. At > > least s|portaudio.h|pa_audio.h| should be done that way. > OK. So, any updates? -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Dmitry Marakasov <amdmi3@amdmi3.ru> writes: > * Denise H. G. (darcsis@gmail.com) wrote: > >> I've made some changes and cleanups. Please check them out. > Now it's still using builtin portaudio, but with includes from > systemwide portaudio. That's even worse :) > > As far as I understand, you need to modify > src/output/portAudio/portAudio.pro to > > - NOT use any sources from src/output/portAudio/PortAudio > - use -lportaduio > Thanks for your advice! I was really confused by those cmake makefile configurations. > Thus it'll use systemwide portaudio and you won't need to patch > builtin portaudio' sources at all. > > PS. Please send updates as a patch to last.fm version I've attached. > This is somehow cleaned up version, with ports/127368 merged. It'll be > too hard to merge changes otherwise. OK. I'll give it another try and stick to the attached version. -- Denise H. G. <darcsis AT gmail DOT com>
State Changed From-To: feedback->closed No activity from submitter