Bug 125564 - sysutils/testdisk configure picks up libs as installed
Summary: sysutils/testdisk configure picks up libs as installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Florent Thoumie
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-13 13:40 UTC by me
Modified: 2008-07-18 10:20 UTC (History)
0 users

See Also:

Attachments
file.diff (1.18 KB, patch)
2008-07-13 13:40 UTC, me 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description me 2008-07-13 13:40:01 UTC 
sysutils/testdisk configure picks up optional dependencies if installed => add '.else CONFIGURE_ARGS+=--without-*' to '.if defined(WITH_*)'

configure picks up iconv if present => add WITH_ICONV OPTION

e2fsprogs does not currently provide ext2fs.so, since it does not do 'make install-libs' => comment out WITH_E2FSPROGS for now (or change e2fsprogs port)

Fix: - add WITH_ICONV to OPTIONS
- for disabled OPTIONS, add CONFIGURE_ARGS+=--without-*
- remove WITH_E2FSPROGS (as long as e2fsprogs does not provide ext2fs.so)

Patch attached with submission follows:
How-To-Repeat: - install sysutils/testdisk with libiconv present

- install sysutils/testdisk with ntfsprogs present but disabled in OPTIONS

- try to install sysutils/testdisk WITH_E2FSPROGS
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-07-13 13:40:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->flz

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-07-18 10:12:58 UTC 
flz         2008-07-18 09:12:49 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/testdisk    Makefile distinfo 
  Log:
  - Update sysutils/testdisk to 6.10.
  - Don't install documentation if NOPORTDOCS is defined.
  - Explicitely disable filesystem support when not selected. [1]
  
  PR:             ports/125564 [1]
  Submitted by:   Jan Henrik Sylvester <me@janh.de> [1]
  
  Revision  Changes    Path
  1.20      +28 -4     ports/sysutils/testdisk/Makefile
  1.14      +6 -3      ports/sysutils/testdisk/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Florent Thoumie freebsd_committer freebsd_triage 2008-07-18 10:13:10 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!