The ports-mgmt/portupgrade tool does not check to see if a given port has defined a custom value for the ECHO_MSG variable when outputing the reason that port has been marked as IGNORE. Since the value used for ECHO_MSG influences the content of the IGNORE variable (for example, ECHO_MSG may be set to /usr/bin/printf, allowing escape codes in ECHO_MSG), blindly outputting the contents of IGNORE can cause ugly or unreadable output. Fix: Patch attached with submission follows: How-To-Repeat: Run portupgrade such that it would try to rebuild java/jdk16 without first downloading tzupdater-1_3_6-2008c.zip. The following will be output (note presence of "\n" in output): ** Port marked as IGNORE: java/jdk16: :\n Due to licensing restrictions, certain files must be fetched manually.\n\n Please open http://java.sun.com/javase/downloads/index.jsp\n in a web browser and follow the \"Download\" link for\n \"JDK US DST Timezone Update Tool - 1_3_6\" to obtain the\n time zone update file, tzupdater-1_3_6-2008c.zip.\n\n Please place the downloaded file(s) in /usr/ports/distfiles \n and restart the build.\n\n
Responsible Changed From-To: freebsd-ports-bugs->sem Over to maintainer (via the GNATS Auto Assign Tool)
Responsible Changed From-To: sem->ruby sem@ has turned over maintainership of portupgrade to the ruby mailing list.
stas 2009-10-26 14:47:49 UTC FreeBSD projects repository Modified files: pkgtools/bin portupgrade Log: - Perform correct formatting of IGNORE message if the port redefines ECHO_MSG to something not equal to 'echo'. PR: ports/125823 Submitted by: Trevor Johns <trevor@tjohns.net> Revision Changes Path 1.62 +11 -3 projects/pkgtools/bin/portupgrade _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!