Bug 125996 - [patch] x11/nvidia-driver - remove pkg_info statements
Summary: [patch] x11/nvidia-driver - remove pkg_info statements
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-27 02:00 UTC by edwin
Modified: 2011-03-14 07:20 UTC (History)
0 users

See Also:

Attachments
file.diff (1.22 KB, patch)
2008-07-27 02:00 UTC, edwin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description edwin 2008-07-27 02:00:13 UTC 

Fix: Cleanup of x11/nvidia-driver
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-07-27 02:01:58 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->danfe

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2008-12-26 18:11:57 UTC 
State Changed
From-To: open->feedback

Last time I checked, it did not work.  If you have relevant analysis 
(or, better, provide reference to bpm revision where it was fixed) I'm 
all ears.  Thanks.
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2009-12-19 17:13:23 UTC 
State Changed
From-To: feedback->open

I don't see why it shouldn't work.  ${PKG_INFO} is defined in bsd.commands.mk 
which is included unconditionally into bsd.port.mk, and in the nvidia-driver 
Makefile it would be used just after bsd.port.pre.mk inclusion, thus is should 
be available.  Can you verify again it's really broken?
Comment 4 danfe 2010-10-09 10:51:36 UTC 
I vaguely recall this behavior on 6.X.  Now I cannot reproduce it on
recent 7.3 or -CURRENT.  I do not have any access to 6.X machines these
days.  I'll commit this diff after 6.X will be officially EOLed.
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-03-14 07:09:24 UTC 
danfe       2011-03-14 07:09:10 UTC

  FreeBSD ports repository

  Modified files:
    x11/nvidia-driver    Makefile 
  Log:
  Now that PKG_INFO macro expands correctly on all supported versions of
  FreeBSD, use it as advised by common sense and XXX statement.
  
  PR:             ports/125996
  Submitted by:   edwin
  
  Revision  Changes    Path
  1.104     +3 -5      ports/x11/nvidia-driver/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Alexey Dokuchaev freebsd_committer freebsd_triage 2011-03-14 07:10:03 UTC 
State Changed
From-To: open->closed

Committed, thanks!