Bug 126210 - [patch] emulators/open-vm-tools pkg-plist and rc script
[patch] emulators/open-vm-tools pkg-plist and rc script
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Any Any
: Normal Affects Only Me
Assigned To: mbr
Depends on:
  Show dependency treegraph
Reported: 2008-08-03 15:00 UTC by ohauer
Modified: 2008-08-03 15:50 UTC (History)
0 users

See Also:

file.diff (1.89 KB, patch)
2008-08-03 15:00 UTC, ohauer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ohauer 2008-08-03 15:00:06 UTC
the port installes vmware-guestd twice, once in ${PREFIX}/sbin and once in ${PREFIX}/bin.

vmware-guestd is installed in ${PREFIX}/sbin by the port own makescript
<-- snip from make -vv package start -->
 Making install in vmSignal
 Making install in wiper
 Making install in guestd
 test -z "/usr/local/sbin" || .././install-sh -c -d "/usr/local/sbin"
   /bin/sh ../libtool --mode=install install  -s -o root -g wheel -m 555 'vmware- guestd' '/usr/local/sbin/vmware-guestd'
 install -o root -g wheel -m 555 -s vmware-guestd /usr/local/sbin/vmware-guestd
<-- snip from make -vv package end -->

<-- snip line from port Makefile start -->
       ${INSTALL} ${WRKSRC}/guestd/vmware-guestd ${PREFIX}/bin/vmware-guestd
</-- snip line from port Makefile end -->

small correction to the rc script:
-checkvm_cmd="${PREFIX}/sbin/vmware-checkvm > /dev/null"
+checkvm_cmd="${PREFIX}/bin/vmware-checkvm > /dev/null"

I have this checked only for open-vm-tools-nox11, since i have nowhere X installed

Fix: Patch attached with submission follows:
How-To-Repeat: Install port emulators/open-vm-tools-nox11
find /usr/local/ -name "vmw*"
=> two versions of vmware-guestd

deinstall the port
find /usr/local/ -name "vmw*"
/usr/local/sbin/vmware-guestd => since pkg-plist knows only the one in ${PREFIX}/bin
Comment 1 Edwin Groothuis freebsd_committer 2008-08-03 15:00:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mbr

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2008-08-03 15:39:27 UTC
mbr         2008-08-03 14:39:11 UTC

  FreeBSD ports repository

  Modified files:
    emulators/open-vm-tools Makefile pkg-plist pkg-plist-x11 
    emulators/open-vm-tools/files vmware-guestd.sh.in 
  vmware-guestd has been installed twice. Fix pkg-plist for this issue.
  Submitted by:   Olli Hauer <ohauer@gmx.de>
  PR:             126210
  Revision  Changes    Path
  1.10      +0 -1      ports/emulators/open-vm-tools/Makefile
  1.3       +2 -2      ports/emulators/open-vm-tools/files/vmware-guestd.sh.in
  1.8       +1 -1      ports/emulators/open-vm-tools/pkg-plist
  1.8       +1 -1      ports/emulators/open-vm-tools/pkg-plist-x11
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 mbr freebsd_committer 2008-08-03 15:40:07 UTC
State Changed
From-To: open->closed

Fixed, thank you.