Bug 126935 - [PATCH] archivers/lzo2: fix build for users not using /bin/sh as root's shell
Summary: [PATCH] archivers/lzo2: fix build for users not using /bin/sh as root's shell
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
Depends on:
Reported: 2008-08-29 09:10 UTC by Sunpoet Po-Chuan Hsieh
Modified: 2008-08-29 14:30 UTC (History)
0 users

See Also:

file.diff (427 bytes, patch)
2008-08-29 09:10 UTC, Sunpoet Po-Chuan Hsieh
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sunpoet Po-Chuan Hsieh 2008-08-29 09:10:03 UTC
The newly-added -x arguemnt is for sh.
Instead of $SHELL, use $SH to call /bin/sh explicitly.
It fixes build for users not using /bin/sh as root's shell.
For me, I use /bin/tcsh as root's shell.

===>  Running self-tests for lzo2-2.03_2 (can take a few minutes, without output)
cd /usr/ports/works/usr/ports/archivers/lzo2/work/lzo-2.03 && make test SHELL="/bin/tcsh -x"
make  all-recursive
Making all in include
Making all in lzo
Making all in src
Making all in lzotest
Making all in examples
Making all in tests
Making all in minilzo
./lzotest/lzotest -mavail -n10 -q ./COPYING
/bin/tcsh -x -e ./util/check.sh .

set -e
set: Variable name must begin with a letter.
*** Error code 1

Stop in /usr/ports/works/usr/ports/archivers/lzo2/work/lzo-2.03.
*** Error code 1

Stop in /usr/ports/archivers/lzo2.
Comment 1 Edwin Groothuis freebsd_committer 2008-08-29 09:10:15 UTC
Maintainer of archivers/lzo2,

Please note that PR ports/126935 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:

Edwin Groothuis via the GNATS Auto Assign Tool
Comment 2 Edwin Groothuis freebsd_committer 2008-08-29 09:10:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Matthias Andree 2008-08-29 12:20:11 UTC

(Note there's a duplicate at ports/126942)

Matthias Andree
Comment 4 dfilter service freebsd_committer 2008-08-29 14:20:25 UTC
miwi        2008-08-29 13:20:11 UTC

  FreeBSD ports repository

  Modified files:
    archivers/lzo2       Makefile 
  - Fix build for users not using /bin/sh as root's shell
  PR:             126935
  Submitted by:   Sunpoet Po-Chuan Hsieh <sunpoet@sunpoet.net>
  Approved by:    maintainer
  Revision  Changes    Path
  1.46      +1 -1      ports/archivers/lzo2/Makefile
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Martin Wilke freebsd_committer 2008-08-29 14:20:27 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!