Bug 127121 - [pf] [patch] pf incorrect log priority
Summary: [pf] [patch] pf incorrect log priority
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 6.4-PRERELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-05 22:20 UTC by Jeff Wheelhouse
Modified: 2018-01-03 05:16 UTC (History)
0 users

See Also:


Attachments
file.diff (395 bytes, patch)
2008-09-05 22:20 UTC, Jeff Wheelhouse
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Wheelhouse 2008-09-05 22:20:05 UTC
If round-robin load balancing is enabled, pf logs a message indicating
which address was chosen for each new state that is created.  This
produces a prodigious amount of information on a busy server, which can
render the server unusable, but the message is logged at priority
PF_DEBUG_MISC.

PF_DEBUG_MISC is identified as for "various errors."  Selecting a
destination address is ordinary operation, not an error.

Therefore I believe the appropriate log level for this message is
PF_DEBUG_NOISY.

Fix: Change PF_DEBUG_MISC to PF_DEBUG_NOISY at line 2407 of pf.c in this revision:

/*      $FreeBSD: src/sys/contrib/pf/net/pf.c,v 1.34.2.8 2007/11/21 13:52:04 dha
rtmei Exp $     */
/*      $OpenBSD: pf.c,v 1.502.2.1 2006/05/02 22:55:52 brad Exp $ */

(Patch enclosed.)

Patch attached with submission follows:
How-To-Repeat: 1. Run "pfctl -x misc" on a busy machine that uses round-robin load balancing. 
2. Cringe.
Comment 1 Remko Lodder freebsd_committer 2008-09-05 23:35:05 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-pf

reassign to pf team
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:58:24 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped