Hello SecTeam, the current format, in which portaudit is printing its URLs is a pain in the ass to copy and paste anywhere. Usually a double click will select the space delimited word under the cursor, but thanks to the surrounding < > you cannot paste this into a browser easily. I also haven't seen <http://foo> used anywhere with URLs, just with email addresses. If there's no good reason to use <URL> please, please drop the surrounding brackets. Fix: This will update the portaudit(1) tool and the printing via ports make(1) The webpage generating script would still need to be adjusted.
Responsible Changed From-To: freebsd-ports-bugs->secteam Over to maintainer (via the GNATS Auto Assign Tool)
On 30 Jan 2011, at 11:45, Ulrich Sp=F6rlein wrote: > the above PR is trivial, but changes the output (to something more > useful, IMHO). Hey, Whoops - that PR is rather ol. Sorry about that. The changes to portaudit looks good. Assuming you have run-time tested = it, it's approved, but also remember to bump PORTVERSION to X.Y.(Z+1). I = don't know if you tried to commit to ports before - if in doubt feel = free to ask :-). The bsd.ports.mk part need to be handled separately as all such changes = need to be portmgr approved. I would probably suggest to either split = that into a separate PR and assign that to portmgr. > Is it known that other scripts are parsing this output? I don't know of any... I know there are an SNMP module which can get = port audit info, but I don't know how it works... --=20 Simon L. B. Nielsen
uqs 2011-01-31 20:17:04 UTC FreeBSD ports repository (src committer) Modified files: ports-mgmt/portaudit Makefile ports-mgmt/portaudit/files portaudit-cmd.sh Log: Don't enclose URLs in <>, it makes them harder to copy&paste and URLs are not email addresses. PR: ports/127214 (first half) Reviewed by: simon Feature safe: yes Revision Changes Path 1.28 +1 -1 ports/ports-mgmt/portaudit/Makefile 1.18 +3 -3 ports/ports-mgmt/portaudit/files/portaudit-cmd.sh _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Responsible Changed From-To: secteam->portmgr Over to portmgr for the bsd.port.mk parts
The changes to port-mgmt/portaudit have been committed, please approve changes to bsd.port.mk. New patch attached.
State Changed From-To: open->analyzed Take for -exp run.
erwin 2011-02-05 15:55:58 UTC FreeBSD ports repository Modified files: Mk bsd.port.mk Log: Drop the use of <> around portaudit URLs PR: 127214 Submitted by: uqs Tested on: pointyhat-west Feature safe: yes Revision Changes Path 1.667 +2 -2 ports/Mk/bsd.port.mk _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: analyzed->closed Committed, thanks!