Fixes problem with Openldap version 2.4 Fix: Apply to following patch: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
> Synopsis: Upgrade of port net/asterisk-app-ldap for openldap 2.4 > > http://www.freebsd.org/cgi/query-pr.cgi?pr=127344 What do you think of improving it a bit: * USE_OPENLDAP assumes dependency on openldapXX-client, no BUILD_DEPEND is needed * USE_ICONV is a shorter way to depend on libiconv * Fix identation * [Depend on USE_OPENLDAP in more correct way] Actually I'm not sure what you intended to archieve with USE_OPENLDAP=24 - bsd.ldap.mk only checks if it's defiened, it never uses the value. According to bsd.ldap.mk, as in my patch, the port will use openldap 2.4 by default, with ability for user to override it by adding corresponding WITH_OPENLDAP_VER in make.conf. However, if it's known that this port only works with specific opneldap version or doesn't work with specific openldap versions, corresponding WANT_OPENLDAP_VER or IGNORE_WITH_OPENLDAP should be set. --- asterisk-app-ldap.patch begins here --- Index: Makefile =================================================================== RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/net/asterisk-app-ldap/Makefile,v retrieving revision 1.3 diff -u -r1.3 Makefile --- Makefile 25 May 2007 11:56:59 -0000 1.3 +++ Makefile 24 Sep 2008 13:34:05 -0000 @@ -7,6 +7,7 @@ PORTNAME= asterisk-app-ldap DISTVERSION= 2.0rc1 +PORTREVISION= 1 CATEGORIES= net MASTER_SITES= http://www.mezzo.net/asterisk/ DISTNAME= app_ldap-${DISTVERSION} @@ -15,13 +16,13 @@ MAINTAINER= idefix@fechner.net COMMENT= LDAPget application module for the Asterisk PBX 1.4 -BUILD_DEPENDS= asterisk:${PORTSDIR}/net/asterisk \ - ${LOCALBASE}/lib/libldap.so:${PORTSDIR}/net/openldap23-client \ - ${LOCALBASE}/lib/libiconv.so:${PORTSDIR}/converters/libiconv +BUILD_DEPENDS= asterisk:${PORTSDIR}/net/asterisk USE_GMAKE= yes +USE_ICONV= yes +USE_OPENLDAP= yes PLIST_FILES= lib/asterisk/modules/app_ldap.so \ - etc/asterisk/ldap.conf.sample + etc/asterisk/ldap.conf.sample .include <bsd.port.mk> --- asterisk-app-ldap.patch ends here --- -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
State Changed From-To: open->feedback Awaiting maintainer's feedback regarding improved patch.
----- Forwarded message from Matthias Fechner <idefix@fechner.net> ----- From: Matthias Fechner <idefix@fechner.net> To: amdmi3@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Cc: Subject: Re: ports/127344: Upgrade of port net/asterisk-app-ldap for openldap 2.4 amdmi3@FreeBSD.org schrieb: > Awaiting maintainer's feedback regarding improved patch. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=127344 I rechecked the port and a switch to another version of LDAP is not possible because other depending packages are enforcing openldap 2.4. I tested the patch and it works fine on a fresh installed FreeBSD. Thanks a lot for your improvement tips, please commit the new version. Bye Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook _______________________________________________ freebsd-ports-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org" ----- End forwarded message -----
State Changed From-To: feedback->closed Committed. Thanks!
amdmi3 2008-09-30 09:24:49 UTC FreeBSD ports repository Modified files: net/asterisk-app-ldap Makefile Log: - Add support for openldap 2.4 - Clean port up a bit PR: 127344 Submitted by: Matthias Fechner <idefix at fechner dot net> (maintainer) Improved by: me (approved by maintainer) Revision Changes Path 1.4 +5 -4 ports/net/asterisk-app-ldap/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"