Bug 128897 - [PATCH] Failture to build arm kernel with "options KTR"
Summary: [PATCH] Failture to build arm kernel with "options KTR"
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: 8.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stanislav Sedov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-15 21:10 UTC by Pankov Pavel
Modified: 2009-01-18 11:50 UTC (History)
0 users

See Also:

Attachments
file.diff (751 bytes, patch)
2008-11-15 21:10 UTC, Pankov Pavel 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pankov Pavel 2008-11-15 21:10:06 UTC 
Building ktr(4)-enabled ARM kernel results in error because of use of undefined variable Maxmem in _bus_dmamap_count_pages function.

Fix: Apply the attached patch.

Patch attached with submission follows:
How-To-Repeat: Add "options KTR" to any ARM kernel config try building kernel.
Comment 1 Stanislav Sedov freebsd_committer freebsd_triage 2008-11-16 09:33:05 UTC 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sat, 15 Nov 2008 21:02:46 GMT
Pankov Pavel <pankov_p@mail.ru> mentioned:

> Building ktr(4)-enabled ARM kernel results in error because of use of undefined variable Maxmem in _bus_dmamap_count_pages function.

Have you checked KTR works at all on ARM kernels?

- -- 
Stanislav Sedov
ST4096-RIPE
-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAkkf6NYACgkQK/VZk+smlYEt2QCdEFc9tg8xyKxzN66RFg5xE+9G
PCYAnRfyo4kWugPNaEEyCH6o9SweU2/a
=6nZH
-----END PGP SIGNATURE-----
Comment 2 Pankov Pavel 2008-11-16 10:53:59 UTC 
> Have you checked KTR works at all on ARM kernels?

Yes, at least verbose and DDB modes work without any problems.
Comment 3 Stanislav Sedov freebsd_committer freebsd_triage 2008-11-30 22:50:37 UTC 
Responsible Changed
From-To: freebsd-arm->stas

I'll take it.
Comment 4 Stanislav Sedov freebsd_committer freebsd_triage 2008-11-30 22:58:38 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2009-01-18 11:43:35 UTC 
Author: stas
Date: Sun Jan 18 11:43:23 2009
New Revision: 187385
URL: http://svn.freebsd.org/changeset/base/187385

Log:
  - Merge r185494:
    Get rid of unused variable in KTR checks. This allows ktr(4) enabled
    ARM kernel to compile.
  
  PR:		rm/128897
  Submitted by:	Pankov Pavel <pankov_p@mail.ru>

Modified:
  stable/7/sys/   (props changed)
  stable/7/sys/arm/arm/busdma_machdep.c
  stable/7/sys/contrib/pf/   (props changed)
  stable/7/sys/dev/ath/ath_hal/   (props changed)
  stable/7/sys/dev/cxgb/   (props changed)

Modified: stable/7/sys/arm/arm/busdma_machdep.c
==============================================================================
--- stable/7/sys/arm/arm/busdma_machdep.c	Sun Jan 18 11:38:35 2009	(r187384)
+++ stable/7/sys/arm/arm/busdma_machdep.c	Sun Jan 18 11:43:23 2009	(r187385)
@@ -671,9 +671,8 @@ _bus_dmamap_count_pages(bus_dma_tag_t dm
 	bus_addr_t paddr;
 
 	if ((map->pagesneeded == 0)) {
-		CTR4(KTR_BUSDMA, "lowaddr= %d Maxmem= %d, boundary= %d, "
-		    "alignment= %d", dmat->lowaddr, ptoa((vm_paddr_t)Maxmem),
-		    dmat->boundary, dmat->alignment);
+		CTR3(KTR_BUSDMA, "lowaddr= %d, boundary= %d, alignment= %d",
+		    dmat->lowaddr, dmat->boundary, dmat->alignment);
 		CTR2(KTR_BUSDMA, "map= %p, pagesneeded= %d",
 		    map, map->pagesneeded);
 		/*
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"