Bug 128987 - [patch] Fix at91_mci and use 1-bit mode.
Summary: [patch] Fix at91_mci and use 1-bit mode.
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: 1.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stanislav Sedov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-19 07:00 UTC by Björn König
Modified: 2009-10-13 11:32 UTC (History)
0 users

See Also:


Attachments
src-sys-arm-at91-at91_mci.c.diff (869 bytes, patch)
2008-11-19 07:00 UTC, Björn König
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Björn König 2008-11-19 07:00:13 UTC
	Currently SD Cards doesn't work with the at91_mci driver
	for AT91RM9200. These changes will make them work:

	- The 4-bit mode of the never worked. Disable it for now.

	- Return 'caps' ivar.

	Probably the 4-bit mode works for other AT91 controllers.
	Therefore it's necessary to find a better solution.
Comment 1 Stanislav Sedov freebsd_committer freebsd_triage 2008-11-30 22:59:57 UTC
Responsible Changed
From-To: freebsd-arm->stas

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-01-20 17:37:13 UTC
Author: mav
Date: Tue Jan 20 17:36:58 2009
New Revision: 187476
URL: http://svn.freebsd.org/changeset/base/187476

Log:
  Implement MMCBR_IVAR_CAPS. It should better be implemented, or results
  can be unpredictable.
  
  PR:		arm/128987

Modified:
  head/sys/arm/at91/at91_mci.c

Modified: head/sys/arm/at91/at91_mci.c
==============================================================================
--- head/sys/arm/at91/at91_mci.c	Tue Jan 20 17:15:12 2009	(r187475)
+++ head/sys/arm/at91/at91_mci.c	Tue Jan 20 17:36:58 2009	(r187476)
@@ -643,6 +643,9 @@ at91_mci_read_ivar(device_t bus, device_
 	case MMCBR_IVAR_VDD:
 		*(int *)result = sc->host.ios.vdd;
 		break;
+	case MMCBR_IVAR_CAPS:
+		*(int *)result = sc->host.caps;
+		break;
 	case MMCBR_IVAR_MAX_DATA:
 		*(int *)result = 1;
 		break;
@@ -683,6 +686,7 @@ at91_mci_write_ivar(device_t bus, device
 		sc->host.ios.vdd = value;
 		break;
 	/* These are read-only */
+	case MMCBR_IVAR_CAPS:
 	case MMCBR_IVAR_HOST_OCR:
 	case MMCBR_IVAR_F_MIN:
 	case MMCBR_IVAR_F_MAX:
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 Gavin Atkinson freebsd_committer freebsd_triage 2009-03-26 12:30:45 UTC
State Changed
From-To: open->patched

Tentatively mark as patched, this appears to have been fixed (or at least 
worked around) in HEAD.
Comment 4 Stanislav Sedov freebsd_committer freebsd_triage 2009-10-13 11:32:32 UTC
State Changed
From-To: patched->closed

Fixed in r187476