The patch adds support of per periodic(8) script nice(1) value the script will be run at. There are two features: * default_nice variable - default nice level * <basename>_<script>_nice variables - nice level for the specific script Default behavior after the patch application is still the same - no nice level changes. periodic.conf(5) example: default_nice=10 daily_status_mail_rejects_enable="YES" daily_status_mail_rejects_nice=8
Can you provide a concrete example of this so I don't have to go reading through ~50 lines of bourne shell and put it in perspective of periodic.conf(5)? Thanks :), -Garrett
Nevermind.. I need to read more closely before I submit ><. Sorry, -Garrett
The only issue with this is that: if [ -n "${_nice}" ] and: elif [ -n "${default_nice}" ] don't check for valid number values. I'm not sure if we'd want to throw in that logic or not (or if there's something else in our rc-scripts that automatically checks for numbers in range)... I'd ask (quickly) on hackers@ to see if the change makes sense for a more widespread review. Cheers, -Garrett
Hi, On Tue, Dec 23, 2008 at 01:44, Garrett Cooper <yanefbsd@gmail.com> wrote: > The only issue with this is that: > > if [ -n "${_nice}" ] > > and: > > elif [ -n "${default_nice}" ] > > don't check for valid number values. I'm not sure if we'd want to > throw in that logic or not (or if there's something else in our > rc-scripts that automatically checks for numbers in range)... > > I'd ask (quickly) on hackers@ to see if the change makes sense for a > more widespread review. Actually the same feature for rc.conf file has no integer value syntax check and produces the same error message from nice(1): nice: qwerty: invalid nice value -- Artem Naluzhnyy
For bugs matching the following criteria: Status: In Progress Changed: (is less than) 2014-06-01 Reset to default assignee and clear in-progress tags. Mail being skipped
Keyword: patch or patch-ready – in lieu of summary line prefix: [patch] * bulk change for the keyword * summary lines may be edited manually (not in bulk). Keyword descriptions and search interface: <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>