Bug 130657 - [ip6] [patch] ipv6 class option
Summary: [ip6] [patch] ipv6 class option
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 7.1-PRERELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tom Jones
Depends on:
Reported: 2009-01-17 20:30 UTC by Alfred Perlstein
Modified: 2020-09-11 07:18 UTC (History)
3 users (show)

See Also:
tuexen: mfc-stable12+

file.diff (1.83 KB, patch)
2009-01-17 20:30 UTC, Alfred Perlstein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alfred Perlstein freebsd_committer 2009-01-17 20:30:01 UTC
	This is in a private version of FreeBSD we have, but the code
        seems to be somewhat close to what we have in FreeBSD.

Fix: Index: bsd/sys/netinet/tcp_syncache.c                                           
RCS file: /cvs/junos-2008/bsd/sys/netinet/tcp_syncache.c,v                      
retrieving revision 1.24                                                        
How-To-Repeat: 	Source inspection, see email audit trail for more information.
Comment 1 Alfred Perlstein freebsd_committer 2009-01-17 20:37:13 UTC
Responsible Changed
From-To: freebsd-bugs->bz

Bjoern asked for this bug.
Comment 2 Alfred Perlstein freebsd_committer 2009-01-17 20:47:19 UTC
adding mailing list discussion to audit trail.

----- Forwarded message from Bruce Simpson <bms@incunabulum.net> -----

From: Bruce Simpson <bms@incunabulum.net>
To: Alfred Perlstein <alfred@freebsd.org>
Cc: net@freebsd.org
Subject: Re: ipv6 bugfix, need review.
Date: Wed, 24 Dec 2008 17:43:43 +0000
Message-ID: <495274CF.3030703@incunabulum.net>
User-Agent: Thunderbird (X11/20081204)
Sender: owner-freebsd-net@freebsd.org

Alfred Perlstein wrote:
>  The traffic class byte is set to 0x00000000 in the header of some
>  BGP packets sent between interfaces that have IPv6 addresses,
>  instead of the correct setting 0xc0 (INTERNETCONTROL).

Content free argument:
   Feels right. I had to commit a man page diff to document the TCLASS 
socket option.
   If this isn't happening for TCP sockets, then that certainly needs 
dealing with.

freebsd-net@freebsd.org mailing list
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"

----- End forwarded message -----

- Alfred Perlstein
Comment 3 Alfred Perlstein freebsd_committer 2009-01-17 20:47:31 UTC
adding mailing list discussion to audit trail.

----- Forwarded message from "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> -----

From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To: Alfred Perlstein <alfred@freebsd.org>
cc: net@freebsd.org
Subject: Re: ipv6 bugfix, need review.
Date: Wed, 24 Dec 2008 23:13:17 +0000 (UTC)
Message-ID: <20081224230540.C97918@maildrop.int.zabbadoz.net>

On Mon, 22 Dec 2008, Alfred Perlstein wrote:


>Fix is small and attached.  One thing I am wondering, do we
>need to check "if (inp)" ?  I don't think so.

I am not that concerned about the inp at the moment; there are a few
other things:

1 FreeBSD to my knowledge has neither IPV6_GET_CLASS nor IPV6_SET_CLASS

2 To the best I can see this currently ignores the upper 4 TC bits that
  go with the `version field' ("vcf"), so it's a hack good enough for
  now, but not a proper fix?

3 I am assuming that we'd need to fix at least one more place.

Tha said I planned to look at the in6p_flowinfo (inp_flow) field in
the not too distant future anyway; I should perhaps combine this
looking into the entire TC thing as well.

Bjoern A. Zeeb                      The greatest risk is not taking one.

----- End forwarded message -----

- Alfred Perlstein
Comment 4 Bjoern A. Zeeb freebsd_committer 2014-05-18 06:01:58 UTC
Responsible Changed
From-To: bz->gnn

I shall not use bugzilla (at least until we will have a CLI).
Comment 5 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:59:27 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 6 Richard Scheffenegger freebsd_committer 2020-09-10 20:00:09 UTC
Patch https://reviews.freebsd.org/D25909 / Commit rS364089 has effectively addressed this reported issue. TCP syncache will retain the ttl and tos (tclass) values and restore them once the session is properly established.
Comment 7 Michael Tuexen freebsd_committer 2020-09-11 07:18:36 UTC
MFCed to stable/12 in base r365563, so the fix will be in 12.2 and higher.