Bug 130724 - [linprocfs] [patch] cpuinfo in linprocfs is dated, causing certain programs dependent on not reported instructions to not run.
Summary: [linprocfs] [patch] cpuinfo in linprocfs is dated, causing certain programs d...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-emulation (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-19 02:00 UTC by Sabeeh Baig
Modified: 2010-03-14 13:40 UTC (History)
0 users

See Also:


Attachments
file.diff (393 bytes, patch)
2009-01-19 02:00 UTC, Sabeeh Baig
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sabeeh Baig 2009-01-19 02:00:09 UTC
I wanted to run Bibble Pro, which is available for Linux and Windows, on FreeBSD.  The installation of the program on FreeBSD was fairly standard, but upon running it, Bibble would quit saying that it requires SSE to run.  Running cat /usr/compat/linux/proc/cpuinfo showed that SSE and SSE2 and SSE3 were not reported, which my CPU has support for.  Looking at the source code confirmed that cpuinfo is indeed static and reports set values for each CPU without checking.  I was able to add entires for SSE and SSE2 to linprocfs.c, but this doesn't seem like a proper solution.  (I've included the patch.)  Why was cpuinfo in linprocfs implemented with static values?  Checking for proper values seems like the better idea, no?  I'd be willing to work on it.

Fix: Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-01-19 08:05:57 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-emulation

Over to maintainer(s).
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-03-14 13:32:59 UTC
Author: gavin
Date: Sun Mar 14 13:32:40 2010
New Revision: 205152
URL: http://svn.freebsd.org/changeset/base/205152

Log:
  Merge r183385 from head (by cognet)
  
    Advertise bit 26 as sse2.
  
  PR:		kern/130724
  Approved by:	cognet

Modified:
  stable/7/sys/compat/linprocfs/linprocfs.c
Directory Properties:
  stable/7/sys/   (props changed)
  stable/7/sys/cddl/contrib/opensolaris/   (props changed)
  stable/7/sys/contrib/dev/acpica/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)

Modified: stable/7/sys/compat/linprocfs/linprocfs.c
==============================================================================
--- stable/7/sys/compat/linprocfs/linprocfs.c	Sun Mar 14 13:29:09 2010	(r205151)
+++ stable/7/sys/compat/linprocfs/linprocfs.c	Sun Mar 14 13:32:40 2010	(r205152)
@@ -222,7 +222,7 @@ linprocfs_docpuinfo(PFS_FILL_ARGS)
 		"sep",	    "sep",     "mtrr",	   "pge",      "mca",
 		"cmov",	    "pat",     "pse36",	   "pn",       "b19",
 		"b20",	    "b21",     "mmxext",   "mmx",      "fxsr",
-		"xmm",	    "b26",     "b27",	   "b28",      "b29",
+		"xmm",	    "sse2",    "b27",	   "b28",      "b29",
 		"3dnowext", "3dnow"
 	};
 
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 Gavin Atkinson freebsd_committer freebsd_triage 2010-03-14 13:33:00 UTC
State Changed
From-To: open->closed

This is fixed in head (r183385) and merged to stable/7.