Bug 130831 - csh(1) core dumps after building libiconv-1.1x from source on 7.0 and 7.1
Summary: csh(1) core dumps after building libiconv-1.1x from source on 7.0 and 7.1
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-21 18:00 UTC by D. Duccini
Modified: 2020-04-17 19:48 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description D. Duccini 2009-01-21 18:00:09 UTC
(The only kernel mod is for IP_FILTER) on this machine

In preparing to load PHP on server, downloaded and built from source libiconv-1.12

after download

./configure
make
make install

noticed core dumps in other builds -- traced to 'csh' and 'tcsh' core-dumping 

lost login ability, but had other window open so I removed /usr/local/lib/libiconv* and csh and tcsh functionality and login ability restored.

Same result with libiconv-1.11 on both Freebsd 7.0 and now this upgraded 7.1 machine.

Box is a Dell 1650, dual 1.4g, 4gb ram, running on top of vmware esxi hypervisor

Fix: 

Delete the newly installed libiconv libraries from /usr/local/lib
How-To-Repeat: 
make install from within libiconv-1.1x source directory
Comment 1 john 2009-06-27 07:51:17 UTC
I encountered the same problem using FreeBSD 7.2.

There is code in bin/csh/iconv_stub.c which attempts to dynamically
load and use iconv.  The problem is it makes assumptions as to
which libiconv it's using (e.g. function names, calling conventions,
parameters, etc).

It's dangerous for there to be any code in the base applications
/ libraries that attempts to use functionality which is not supplied
by the base libraries.

The enclosed patch resolved the problem for me.

-- John
------------------------8<------------------------------8<---------------
--- bin/csh/iconv_stub.c.ORIGINAL	2009-04-14 23:14:26.000000000 -0400
+++ bin/csh/iconv_stub.c	2009-05-18 21:45:20.000000000 -0400
@@ -57,8 +57,10 @@ dl_iconv_open(const char *tocode, const 
 			return (iconv_t)-1;
 	} else {
 		initialized = 1;
+/*
 		iconvlib = dlopen(ICONVLIB, RTLD_LAZY | RTLD_GLOBAL);
 		if (iconvlib == NULL)
+*/
 			return (iconv_t)-1;
 		iconv_open = (iconv_open_t *)dlfunc(iconvlib, ICONV_OPEN);
 		dl_iconv = (dl_iconv_t *)dlfunc(iconvlib, ICONV_ENGINE);
-------------------------------------------------------------------------
|   Feith Systems  |   Voice: 1-215-646-8000  |  Email: john@feith.com  |
|    John Wehle    |     Fax: 1-215-540-5495  |                         |
-------------------------------------------------------------------------
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:49 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2020-04-17 19:48:44 UTC
This must have been fixed long time ago.  Feel free to reopen if not.