1) To avoid subtle compatibility problems that may occur with the mixing of different compilers, use C and C++ compilers or compiler front-ends from the same compiler suite as the Fortran compiler when USE_FORTRAN is defined, whenever possible; 2) Output an error message when an unexpected value is given for USE_FORTRAN; 3) Fix the OSVERSION for which lang/gcc34 should be used when USE_FORTRAN=g77 : http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/freebsd-versions.html#AEN6173 states that gcc 4.2.x wasn't imported into the base system until 700042; 4) Add RUN_DEPENDS to the output of the test-gcc target. Questions: Should lang/icc be used when USE_FORTRAN=ifort? Should USE_GCC and USE_FORTRAN also fix the objective-C compiler, in case one is used? Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->gerald bsd.gcc.mk is gerald territory (via the GNATS Auto Assign Tool)
gerald 2009-02-02 01:45:13 UTC FreeBSD ports repository Modified files: Mk bsd.gcc.mk Log: Set CC and CXX to match the choice of GNU Fortran compilers for C and C++, too, to avoid subtle compatibility problems. Diagnose the case where an unexpected value is provided for USE_FORTRAN. Fix the OSVERSION for which lang/gcc34 should be used foor USE_FORTRAN=g77 according to our Porters Handbook. Add RUN_DEPENDS to the output of the test-gcc target. PR: 131114 Submitted by: bf2006a@yahoo.com Revision Changes Path 1.27 +16 -7 ports/Mk/bsd.gcc.mk _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed I committed the subset of this patch that is described in the comments (basically omitting USE_FORTRAN=gfortran44) with some improvements in terms of formatting. Thanks for the submission!