Bug 131955 - multimedia/libxine links libfaad.so.2 if present
Summary: multimedia/libxine links libfaad.so.2 if present
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: MANTANI Nobutaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-21 23:10 UTC by me
Modified: 2009-02-22 14:40 UTC (History)
0 users

See Also:

Attachments
file.diff (917 bytes, patch)
2009-02-21 23:10 UTC, me 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description me 2009-02-21 23:10:02 UTC 
If libfaad.so.2 from audio/faad is installed, multimedia/libxine uses it instead of building the internal one. The dependency is not recorded.

There should be an OPTION, if the internal or external libfaad is to be used.

It could default to off, since the dependency was not in the default package before.

Or it could default to on, since configure states:

--with-external-libfaad use external libfaad (recommended)

Fix: The patch attached adds an OPTION WITH_FAAD that will configure --with-external-libfaad=yes and record the dependency if on and configure --with-external-libfaad=no otherwise. (The default is off to be conservative, but that is against recommendation in configure.)


Patch attached with submission follows:
How-To-Repeat: - install audio/faad
- install multimedia/libxine
- readelf -d /usr/local/lib/xine/plugins/1.24/xineplug_decode_faad.so
- observe that libfaad.so.2 is NEEDED
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-02-21 23:10:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->nobutaka

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-02-22 14:35:06 UTC 
nobutaka    2009-02-22 14:34:56 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/libxine   Makefile distinfo pkg-plist 
    multimedia/libxine/files patch-configure 
                             patch-misc_Makefile.in 
  Added files:
    multimedia/libxine/files patch-src_combined_ffmpeg_Makefile.in 
  Removed files:
    multimedia/libxine/files patch-src__xine-engine__buffer.h 
  Log:
  - Update to 1.1.16.2.
  - Add FAAD option for external libfaad support. [*]
  
  PR:             ports/131955 [*]
  Submitted by:   Jan Henrik Sylvester <me@janh.de>
  
  Revision  Changes    Path
  1.141     +11 -4     ports/multimedia/libxine/Makefile
  1.39      +3 -3      ports/multimedia/libxine/distinfo
  1.10      +51 -7     ports/multimedia/libxine/files/patch-configure
  1.2       +5 -5      ports/multimedia/libxine/files/patch-misc_Makefile.in
  1.2       +0 -11     ports/multimedia/libxine/files/patch-src__xine-engine__buffer.h (dead)
  1.1       +13 -0     ports/multimedia/libxine/files/patch-src_combined_ffmpeg_Makefile.in (new)
  1.53      +2 -0      ports/multimedia/libxine/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 MANTANI Nobutaka freebsd_committer freebsd_triage 2009-02-22 14:35:29 UTC 
State Changed
From-To: open->closed

Committed, thanks!