Bug 132144 - [PATCH]lang/tcl85: unbreak build WITH_TCL85_MAN, fix plist WITH_TZDATA
[PATCH]lang/tcl85: unbreak build WITH_TCL85_MAN, fix plist WITH_TZDATA
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Any Any
: Normal Affects Only Me
Assigned To: Martin Matuska
Depends on:
  Show dependency treegraph
Reported: 2009-02-27 00:20 UTC by bf2006a
Modified: 2009-02-27 07:12 UTC (History)
0 users

See Also:

file.diff (1.74 KB, patch)
2009-02-27 00:20 UTC, bf2006a
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bf2006a 2009-02-27 00:20:01 UTC
The install target is broken if WITH_TCL85_MAN is defined:

"/bin/mkdir -p /usr/local/share/tcl8.5
install  -o root -g wheel -m 444 /tmp/usr/ports/lang/tcl85/work/tcl8.5.6/unix/../doc/man.macros /usr/local/share/tcl8.5
/bin/mkdir -p /usr/local/man/man1
install  -o root -g wheel -m 444 /tmp/usr/ports/lang/tcl85/work/tcl8.5.6/unix/../doc/tclsh.1 /usr/local/man/man1/tclsh8.5.1
sed: /tmp/usr/ports/lang/tcl85/work/tcl8.5.6/unix/../doc/tclsh8.5.1: No such file or directory
*** Error code 1"

Also, there is a superfluous empty line, and the plist is missing some files
in the WITH_TZDATA case.

Since this is an important port, there should be more testing, even of non-default
OPTIONS, before future commits.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2009-02-27 00:20:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2009-02-27 07:09:15 UTC
mm          2009-02-27 07:09:02 UTC

  FreeBSD ports repository

  Modified files:
    lang/tcl85           Makefile pkg-plist 
    x11-toolkits/tk85    Makefile 
  - Unbreak install if WITH_*_MAN set
  - fix pkg-plist for TZDATA in tcl85
  PR:             ports/132144, ports/132147
  Submitted by:   bf <bf2006a@yahoo.com>
  Revision  Changes    Path
  1.22      +1 -1      ports/lang/tcl85/Makefile
  1.9       +2 -0      ports/lang/tcl85/pkg-plist
  1.24      +1 -1      ports/x11-toolkits/tk85/Makefile
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Martin Matuska freebsd_committer 2009-02-27 07:12:21 UTC
State Changed
From-To: open->closed

Committed. Thanks!