Bug 13309 - [patch] Fixes to nos-tun(8)
Summary: [patch] Fixes to nos-tun(8)
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 4.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1999-08-21 23:40 UTC by Nick Johnson
Modified: 2018-05-20 23:57 UTC (History)
0 users

See Also:


Attachments
file.diff (5.97 KB, patch)
1999-08-21 23:40 UTC, Nick Johnson
no flags Details | Diff
file.diff (2.04 KB, patch)
1999-08-21 23:40 UTC, Nick Johnson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Johnson 1999-08-21 23:40:01 UTC
The return values from write and send are not checked in nos-tun.  In
addition, functionality to shut down & re-set-up a link when sends repeatedly
fail is nice, especially in the case of a dynamic IP/DNS environment.

Code structure left a bit to be desired.

Fix: Patches to nos-tun.c:

Patches to nos-tun.8:
Comment 1 hoek freebsd_committer 1999-08-22 21:07:44 UTC
Responsible Changed
From-To: gnats-admin->freebsd-bugs

Misfiled PR 

Comment 2 tim 1999-08-22 21:23:30 UTC
>
>+/*
>+ * 19990727 - Nick Johnson <freebsd@spatula.net>
>+ * Added -r and -w flags, cleaned up the code a bit,
>+ * made writes more robust (return values were not being
>+ * checked)
>+ */

Don't include these type of comments.  We have cvs do this for us.


>-void Finish(int signum)
>+void Cleanup()
> {

I guess there's no prototype for this function.


>+  if(Set_address(target, to))
>+    return(4);

To maintain consistency with the existing nos-tun.c, consider using
a "{ ... }" block even if it's not needed.


>-end, a concept cisco doesn't really implement.
>+end, a concept Cisco doesn't really implement.  Destination may be
>+a hostname.

To make keeping the translated manpages synchronized with their
English versions easier, don't gratuitously change a line.  The
sentence you added should have been started on a new line.

[Actually, there has been some suggestion that standard mdoc style is
 to start sentences on newlines in most cases...  You may consider this,
 too...  It means that future changes are clearer and easier to read ---
 once again important for people doing translation.]


>-address set on the remote end.
>+address set on the remote end.  Target may be a hostname.

Same.
Comment 3 iedowse freebsd_committer 2002-01-20 18:23:56 UTC
State Changed
From-To: open->feedback


Is this problem still present? If so, do you have an update patch as 
per the comments in the audit trail?
Comment 4 bill fumerola freebsd_committer 2002-01-21 20:54:27 UTC
State Changed
From-To: feedback->open

these patches are still relevent 


Comment 5 bill fumerola freebsd_committer 2002-01-21 20:54:27 UTC
Responsible Changed
From-To: freebsd-bugs->billf

i will work with the submitter (as i know him) to generate 
updated patches and test them.
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2007-03-14 23:00:07 UTC
State Changed
From-To: open->feedback

To submitter: are these patches still relevant? 


Comment 7 Mark Linimon freebsd_committer freebsd_triage 2007-03-14 23:00:07 UTC
Responsible Changed
From-To: billf->linimon

Assignee did not respond to request for status of this PR, so reassign 
to the pool.
Comment 8 Mark Linimon freebsd_committer freebsd_triage 2007-05-06 01:39:03 UTC
State Changed
From-To: feedback->suspended

Since no one responded to my request for status on this PR, just set 
it to 'suspended'. 


Comment 9 Mark Linimon freebsd_committer freebsd_triage 2007-05-06 01:39:03 UTC
Responsible Changed
From-To: linimon->freebsd-bugs
Comment 10 Eitan Adler freebsd_committer freebsd_triage 2018-05-20 23:57:18 UTC
For bugs matching the following conditions:
- Status == In Progress
- Assignee == "bugs@FreeBSD.org"
- Last Modified Year <= 2017

Do
- Set Status to "Open"