Bug 133354 - [PATCH] audio/openal: fix segfault in some cases
Summary: [PATCH] audio/openal: fix segfault in some cases
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-04 02:10 UTC by Dmitry Marakasov
Modified: 2009-04-07 23:30 UTC (History)
1 user (show)

See Also:


Attachments
openal-20060211_9.patch (1.23 KB, patch)
2009-04-04 02:10 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2009-04-04 02:10:01 UTC
When _alFloatMul is called on a very small buffer consisting of <= 2 samples, buffer length will be calculated incorrectly (512MB), which will lead to segfault. The patch fixes this and also improves performance a tiny bit (when buffer is aligned, first 4 samples will now be processed with mmx as they should).

Added file(s):
- files/patch-src-arch-i386-x86_floatmul.c

Port maintainer (erik@smluc.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer 2009-04-04 02:10:10 UTC
Maintainer of audio/openal,

Please note that PR ports/133354 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/133354

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2009-04-04 02:10:12 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Dmitry Marakasov freebsd_committer 2009-04-04 02:22:40 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 4 Dmitry Marakasov freebsd_committer 2009-04-07 23:17:49 UTC
State Changed
From-To: feedback->closed

Committed with portmgr approval.  Sorry for committing it without your 
approval, but it really affects many ports and blocks some other updates 
I'd like to make before the freeze.
Comment 5 dfilter service freebsd_committer 2009-04-07 23:17:52 UTC
amdmi3      2009-04-07 22:17:39 UTC

  FreeBSD ports repository

  Modified files:
    audio/openal         Makefile 
  Added files:
    audio/openal/files   patch-src-arch-i386-x86_floatmul.c 
  Log:
  - Fix segfault under certain conditions
  
  PR:             133354
  Submitted by:   myself
  Approved by:    pav@
  
  Revision  Changes    Path
  1.52      +1 -1      ports/audio/openal/Makefile
  1.1       +11 -0     ports/audio/openal/files/patch-src-arch-i386-x86_floatmul.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"