Bug 133927 - [patch] bsd.openssl.mk: silence warnings when OPENSSL_INSTALLED is empty
Summary: [patch] bsd.openssl.mk: silence warnings when OPENSSL_INSTALLED is empty
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-22 21:00 UTC by Eygene Ryabinkin
Modified: 2009-05-07 09:24 UTC (History)
0 users

See Also:


Attachments
bsd.openssl.mk-fix-empty-grep-args.diff (1.30 KB, patch)
2009-04-22 21:00 UTC, Eygene Ryabinkin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eygene Ryabinkin 2009-04-22 21:00:01 UTC
While doing 'port test' for 'devel/git' I had seen the following
warning messages:
-----
grep: : No such file or directory
grep: : No such file or directory
"/usr/ports/Mk/bsd.openssl.mk", line 111: warning: "grep "^lib/libssl.so." """ returned non-zero status
-----

The appear because porttools use /tmp/<something> as the package
database and build the port without dependencies.  This should not
happen for real port building, because OpenSSL dependency should
be satisfied first.

Fix: The following patch shuts the warning messages:
How-To-Repeat: 
Do 'port test' for 'devel/git' or some other port that requires
OpenSSL from ports.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-04-22 21:00:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

bsd.openssl.mk is dinoex territory (via the GNATS Auto Assign Tool)
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2009-04-29 09:02:03 UTC
State Changed
From-To: open->feedback


Please check. 
The grep should never returnan empty string. 
unless your /var/db/pkg is messed up badly. 

please tell the output off: 
$ ls -l /usr/local/lib/libcrypto.* 

$ cd /usr/ports/devel/git && make -V PKG_DBDIR 

I don't know the "port" command, where dioes it com from? 
$ pkg:_info -w port
Comment 3 Eygene Ryabinkin 2009-04-29 13:18:59 UTC
Dirk, good day.

Wed, Apr 29, 2009 at 10:09:56AM +0200, dinoex@FreeBSD.org wrote:
> Synopsis: [patch] bsd.openssl.mk: silence warnings when OPENSSL_INSTALLED is empty
> 
> State-Changed-From-To: open->feedback
> State-Changed-By: dinoex
> State-Changed-When: Wed Apr 29 10:02:03 CEST 2009
> State-Changed-Why: 
> 
> Please check.
> The grep should never returnan empty string.
> unless your /var/db/pkg is messed up badly.

It's not /var/db/pkg, it is /tmp/<something> as set by the porttools.
Normal package builds have it set to /var/db/pkg and everything is fine.
Please, see below for explanations.

> please tell the output off:
> $ ls -l /usr/local/lib/libcrypto.*

Libraries are here.

> $ cd /usr/ports/devel/git && make -V PKG_DBDIR

Of course, /var/db/pkg.

> I don't know the "port" command, where dioes it com from?
> $ pkg:_info -w port

Here lies the badness: 'port' is from the port-mgmt/porttools suite that
I use for port testing and validation.  The utility sets PKG_DBDIR to
the freshly created directory in /tmp and sets NO_DEPENDS, so this is
the reason why OpenSSL stuff isn't detected -- it isn't recorded in the
'fake' PKG_DBDIR and isn't built because NO_DEPENDS is here.
-- 
Eygene
 _                ___       _.--.   #
 \`.|\..----...-'`   `-._.-'_.-'`   #  Remember that it is hard
 /  ' `         ,       __.--'      #  to read the on-line manual
 )/' _/     \   `-_,   /            #  while single-stepping the kernel.
 `-'" `"\_  ,_.-;_.-\_ ',  fsc/as   #
     _.-'_./   {_.'   ; /           #    -- FreeBSD Developers handbook
    {_.-``-'         {_/            #
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-05-07 09:19:17 UTC
dinoex      2009-05-07 08:19:02 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.openssl.mk 
  Log:
  - Fix autodetec with invalid PKG_DBDIR
  PR:             133927
  Submitted by:   Eygene Ryabinkin
  
  Revision  Changes    Path
  1.43      +7 -1      ports/Mk/bsd.openssl.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Dirk Meyer freebsd_committer freebsd_triage 2009-05-07 09:23:59 UTC
State Changed
From-To: feedback->closed

committed, thanks.