Bug 135403 - [PATCH] graphics/kipi-plugins-kde4: Fix build
Summary: [PATCH] graphics/kipi-plugins-kde4: Fix build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kris Moore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-09 09:30 UTC by Jason E. Hale
Modified: 2009-06-17 16:10 UTC (History)
1 user (show)

See Also:


Attachments
2009-06-09-kipi-plugins-kde4.diff (26.14 KB, patch)
2009-06-09 09:30 UTC, Jason E. Hale
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale 2009-06-09 09:30:06 UTC
Build for graphics/kipi-plugins-kde4 fails if QT3 and KDE3 versions of kipi,
kdcraw, and kexiv2 are installed.

1. Port fails to build with multiple errors due to QT3 style headers.
2. When KDE3 versions of kipi, kdcraw, and kexiv2 are installed, they are
   detected instead of KDE4 versions.
3. IpodExport plugin requires audio/libgpod >= 0.7.0; currently ports has 0.6.0
4. Gdk and Gpod don't get detected properly.

Fix: Use attached diff to fix build.

1. Patch includes replacement list to convert QT3 style headers to QT4 style.
2. Fix patch-CMakeLists.txt so that KDE4 versions of kipi, kdcraw, and kexiv2
   are detected.
3. Disable required libraries for IpodExport and remove dependency on
   audio/libgpod.
4. Fix Find*.cmake so Gdk and Gpod get detected.

Misc:
- kdebase is not needed as dependency; it is only needed for wallpaper plugin
  which is currently disabled
- add more specific QT_COMPONENTS
- remove entries from pkg-plist that are installed by kdehier
- bump PORTREVISION due to dependency changes
	
How-To-Repeat: Try to build graphics/kipi-plugins-kde4 with QT3 and KDE3 versions of kipi
installed.
Comment 1 Edwin Groothuis freebsd_committer 2009-06-09 09:30:15 UTC
Maintainer of graphics/kipi-plugins-kde4,

Please note that PR ports/135403 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/135403

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2009-06-09 09:30:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Kris Moore 2009-06-09 15:04:35 UTC
Thanks for the patch! I've built with it here, and it seems to work just 
fine. I'll see about getting this committed here soon.


-- 

Kris Moore
PC-BSD Software
http://www.pcbsd.com
Comment 4 Kris Moore freebsd_committer 2009-06-09 15:24:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kmoore

I'll take it.
Comment 5 dfilter service freebsd_committer 2009-06-17 16:02:37 UTC
kmoore      2009-06-17 15:02:19 UTC

  FreeBSD ports repository

  Modified files:
    graphics/kipi-plugins-kde4 Makefile pkg-plist 
    graphics/kipi-plugins-kde4/files patch-CMakeLists.txt 
  Log:
  - Fix building of kipi-plugins-kde4 if QT3 / KDE3 versions of kipi are installed
  
  - Fix detection of Gdk / Gpod
  
  PR: 135403
  Submitted by: Jason E. Hale <bsdkaffee@gmail.com>
  Approved by:    miwi (Mentor)
  
  Revision  Changes    Path
  1.49      +14 -4     ports/graphics/kipi-plugins-kde4/Makefile
  1.2       +57 -184   ports/graphics/kipi-plugins-kde4/files/patch-CMakeLists.txt
  1.19      +17 -230   ports/graphics/kipi-plugins-kde4/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Kris Moore freebsd_committer 2009-06-17 16:09:20 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!