Bug 136206 - [patch] bsd.linux-rpm.mk: OVERRIDE_LINUX_NONBASE_PORTS not honored
Summary: [patch] bsd.linux-rpm.mk: OVERRIDE_LINUX_NONBASE_PORTS not honored
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-emulation (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-01 03:20 UTC by Nathan Whitehorn
Modified: 2009-07-01 21:40 UTC (History)
0 users

See Also:

Attachments
file.diff (541 bytes, patch)
2009-07-01 03:20 UTC, Nathan Whitehorn 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Whitehorn freebsd_committer freebsd_triage 2009-07-01 03:20:02 UTC 
After the change to Fedora 10 as the default Linux base on -CURRENT, you get messages like this even if OVERRIDE_LINUX_NONBASE_PORTS is set to f8:

** Port marked as IGNORE: x11/linux-f8-xorg-libs:
        bsd.linux-rpm.mk test failed: default package building at OSVERSION>=800076 was changed to linux-f10 ports, please define OVERRIDE_LINUX_NONBASE_PORTS to build other linux infrastructure ports

Fix: This is due to over-enthusiastic application of curly braces in the test on line 70 of bsd.linux-rpm.mk. Instead of testing defined(${OVERRIDE_LINUX_NONBASE_PORTS}), it should test defined(OVERRIDE_LINUX_NONBASE_PORTS).

Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-07-01 04:25:11 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-emulation

Over to maintainer(s).
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-07-01 21:35:48 UTC 
bsam        2009-07-01 20:35:34 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.linux-rpm.mk 
  Log:
  Honor OVERRIDE_LINUX_NONBASE_PORTS=f8 after the change to Fedora 10
  as the default Linux base on -CURRENT.
  
  PR:             ports/136206
  Submitted by:   nwhitehorn
  
  Revision  Changes    Path
  1.22      +2 -2      ports/Mk/bsd.linux-rpm.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Boris Samorodov freebsd_committer freebsd_triage 2009-07-01 21:36:05 UTC 
State Changed
From-To: open->closed

Committed, thanks!