Bug 137405 - [PATCH] devel/pwlib: mark MAKE_JOBS_UNSAFE, minor nits
Summary: [PATCH] devel/pwlib: mark MAKE_JOBS_UNSAFE, minor nits
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-04 00:50 UTC by Dmitry Marakasov
Modified: 2009-08-29 00:02 UTC (History)
1 user (show)

See Also:


Attachments
pwlib-1.12.0_5,1.patch (864 bytes, patch)
2009-08-04 00:50 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2009-08-04 00:50:03 UTC
Mark MAKE_JOBS_UNSAFE, fails with forced jobs:
http://people.freebsd.org/~amdmi3/pwlib.log

While here, use SF macro, fix EXTRACT_SUFX weirdness and remove
unneeded WANT_GNOME.

Port maintainer (steve@energistic.com) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-04 00:50:20 UTC
Maintainer of devel/pwlib,

Please note that PR ports/137405 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/137405

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-04 00:50:22 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2009-08-04 15:04:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 4 Steve Ames 2009-08-27 16:55:27 UTC
This is fine.
Comment 5 Dmitry Marakasov 2009-08-27 17:23:10 UTC
* Steve Ames (steve@energistic.com) wrote:

> This is fine.

Thanks. The same thing for openh323

--- openh323.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/net/openh323/Makefile,v
retrieving revision 1.83
diff -u -r1.83 Makefile
--- Makefile	5 Jan 2009 19:04:27 -0000	1.83
+++ Makefile	27 Aug 2009 15:59:45 -0000
@@ -9,9 +9,10 @@
 PORTVERSION=	1.19.0.1
 PORTREVISION=	1
 CATEGORIES=	net
-MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
-DISTNAME=	openh323/${PORTNAME}-v${PORTVERSION:S/./_/g}-src-
-EXTRACT_SUFX=	tar.gz
+MASTER_SITES=	SF
+DISTNAME=	${PORTNAME}-v${PORTVERSION:S/./_/g}-src
+EXTRACT_SUFX=	-tar.gz
+DIST_SUBDIR=	openh323
 
 MAINTAINER=	steve@energistic.com
 COMMENT=	A H323 Video Conferencing library
--- openh323.patch ends here ---

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 6 Steve Ames 2009-08-27 17:24:02 UTC
Also good. I was unaware of DIS_SUBDIR. Much cleaner.
Comment 7 Dmitry Marakasov 2009-08-27 17:40:53 UTC
* Steve Ames (steve@energistic.com) wrote:

> Also good. I was unaware of DIS_SUBDIR. Much cleaner.

Ok. Also, the PR was forwarded to jmelo@, how do you think, should I wait
for his approval or it's ok to commit it right away?

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 8 Steve Ames 2009-08-27 18:13:53 UTC
Dmitry Marakasov wrote:
> Ok. Also, the PR was forwarded to jmelo@, how do you think, should I
> wait for his approval or it's ok to commit it right away?

Unsure. I don't know jmelo@...
Comment 9 Mark Linimon freebsd_committer freebsd_triage 2009-08-28 17:07:30 UTC
State Changed
From-To: feedback->open

Approved by maintainer (see manually edited Audit-Trail).
Comment 10 Dmitry Marakasov freebsd_committer freebsd_triage 2009-08-29 00:02:45 UTC
State Changed
From-To: open->closed

Committed. Thanks!