Bug 137454 - [patch] math/p5-Math-GSL: Fix issue with finding headers
Summary: [patch] math/p5-Math-GSL: Fix issue with finding headers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-05 10:10 UTC by Earl Gay
Modified: 2009-08-06 23:30 UTC (History)
0 users

See Also:


Attachments
file.diff (464 bytes, patch)
2009-08-05 10:10 UTC, Earl Gay
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Earl Gay 2009-08-05 10:10:10 UTC
The build fails due to a bug in inc/GSLBuilder.pm that adds broken arguments when building the module. It's essentially passing "-I -I/usr/local/lib/perl5/5.8.9/mach/CORE/", since there is an extra -I it doesn't actually pass the needed include path. 

The reason it is adding the extra -I is because there is a check to see if an array is defined, and if so it wants to add all of the elements to the include path list. The problem is that the array is always defined but it may just contain one blank element. The included patch checks to see if that element is empty and makes adjustments accordingly. 

I've tested the patch to fix the issue on 7.2-RELEASE(i386) and 8.0-BETA2(i386).

Fix: Copy the attached patch to: files/patch-inc-GSLBuilder.pm

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-05 10:10:18 UTC
Maintainer of math/p5-Math-GSL,

Please note that PR ports/137454 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/137454

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-05 10:10:21 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2009-08-05 17:31:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 4 wenheping 2009-08-06 00:30:51 UTC
I approve it.
Thank you.

wen
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2009-08-06 23:25:28 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2009-08-06 23:25:32 UTC
miwi        2009-08-06 22:25:18 UTC

  FreeBSD ports repository

  Added files:
    math/p5-Math-GSL/files patch-inc-GSLBuilder.pm 
  Log:
  - Fix build
  
  PR:             137454
  Submitted by:   Earl Gay <earl@eeg3.net>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.1       +17 -0     ports/math/p5-Math-GSL/files/patch-inc-GSLBuilder.pm (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"