Bug 138687 - [PATCH] mail/roundcube: fix broken password plugin's parsing of email usernames
Summary: [PATCH] mail/roundcube: fix broken password plugin's parsing of email usernames
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alex Dupre
Depends on:
Reported: 2009-09-10 04:50 UTC by Sahil Tandon
Modified: 2009-09-10 09:20 UTC (History)
0 users

See Also:

file.diff (929 bytes, patch)
2009-09-10 04:50 UTC, Sahil Tandon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sahil Tandon 2009-09-10 04:50:01 UTC
The recent update to 0.3 introduced a plugins/ directory that is now distributed with the software.  Unfortunately, the password plugin has a broken SQL driver.  According to the documentation, '%d' is supposed to be replaced with the domain part of a username in case the IMAP username is an email address.  However, the PHP code just passes the local-part of the username instead.  The fix is trivial and should obviously be adopted upstream.  Until this is done (I have tried to contact the author), this patch fixes the problem.

CVS diff attached.

Fix: Apply patch.

Patch attached with submission follows:
How-To-Repeat: Use an SQL password_query that employs the '%d' expansion.  Notice that the local-part (instead of the domain name) is passed to SQL.
Comment 1 Edwin Groothuis freebsd_committer 2009-09-10 04:50:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2009-09-10 09:19:37 UTC
ale         2009-09-10 08:19:29 UTC

  FreeBSD ports repository

  Added files:
    mail/roundcube/files patch-plugins_password_drivers_sql.php 
  Fix password plugin.
  PR:             ports/138687
  Submitted by:   Sahil Tandon <sahil@tandon.net>
  Revision  Changes    Path
  1.1       +11 -0     ports/mail/roundcube/files/patch-plugins_password_drivers_sql.php (new)
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Alex Dupre freebsd_committer 2009-09-10 09:19:38 UTC
State Changed
From-To: open->closed

Committed, thanks!