Bug 138846 - www/apache22 mod_proxy optional patch is not applied by the Makefile
Summary: www/apache22 mod_proxy optional patch is not applied by the Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-15 16:20 UTC by George D.
Modified: 2009-12-11 23:00 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George D. 2009-09-15 16:20:07 UTC 
	The optional patch for the mod_proxy_connect which can be enabled and disabled throught the config options is not getting applied
	regardless of whether the option is turned on or off.
	This is happening because the Makefile is checking for a wrong variable and not setting the EXTRA_PATCHES variable.

Fix: Apply the following patch to the www/apache22/Makefile :



#optionally enable mod_proxy_connect patch
-.if defined(PATCH_PROXY_CONNECT)
+.if defined(WITH_PATCH_PROXY_CONNECT)
 EXTRA_PATCHES+= ${FILESDIR}/opt-patch-modules:proxy:mod_proxy_connect.c
 .endif--XgbvAnwiZYzyRXvDxLfN5BPbI5wEIP3KbC9mP4yE4EnsbDlC
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.org        2009-09-15 08:35:07.000000000 -0400
+++ Makefile    2009-09-15 08:35:32.000000000 -0400
@@ -189,7 +189,7 @@ show-options:
        @${SED} -ne 's/^##//p' ${APACHEDIR}/Makefile.doc
How-To-Repeat: 	The following steps reproduce the issue:
	- cd into the www/apache22 folder
	- run "make extract"
	- save the modules/proxy/mod_proxy_connect.c file to a different location
	- run "make config"
	- check that the PATCH_PROXY_CONNECT option is turned on
	- run "make patch"
	- check that the modules/proxy/mod_proxy_connect.c file has not changed compared to the original file
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-15 16:20:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->apache

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Philip M. Gollucci freebsd_committer freebsd_triage 2009-12-10 10:35:25 UTC 
Responsible Changed
From-To: apache->pgollucci

I'll take it.
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2009-12-11 22:57:36 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-12-11 22:57:38 UTC 
pgollucci    2009-12-11 22:57:29 UTC

  FreeBSD ports repository

  Modified files:
    www/apache22         Makefile 
  Log:
  - Fix option WITH_PATCH_PROXY_CONNECT
  
  PR:             ports/138846
  Submitted by:   "George D." <gi@azagal.com>
  
  Revision  Changes    Path
  1.246     +2 -2      ports/www/apache22/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"