Bug 139676 - maintainer update x11/xlockmore
Summary: maintainer update x11/xlockmore
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-16 09:20 UTC by marius
Modified: 2009-10-18 12:20 UTC (History)
0 users

See Also:


Attachments
file.diff (1.03 KB, patch)
2009-10-16 09:20 UTC, marius
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description marius 2009-10-16 09:20:05 UTC
Patch attached.
Many thanks to David Wolfskill and David A. Bagley.

Fix: Patch attached with submission follows:
Comment 1 david 2009-10-16 18:22:39 UTC
Please note that the reason xlockmore 5.29.1 was released is that 5.29
will fail if invoked from within certain "virtual" window managers.

The failure is accompanied by a message:

| X Error of failed request:  BadWindow (invalid Window parameter)
|   Major opcode of failed request:  3 (X_GetWindowAttributes)
|   Resource id in failed request:  0x45
|   Serial number of failed request:  82
|   Current serial number in output stream:  83

and xlockmore fails to actually lock the screen.

(I specifically observed it with the piewm and tvtwm window managers,
and noted that the failure does not occur using the twm window
manager.  I believe that in general, window managers based on tvtwm are
susceptible.  It is possible that any "virtual" window manager is
susceptible.)

As a common way to invoke xlock(more) is via xautolock (in which case,
the message is not generally displayed in a place where anyone would see
it), the overall effect is that one would leave the computer, expecting
that xlock(more) would offer at least some protection, while in fact,
nothing of the sort happens: the machine is merely left logged in and
unattended.

This is probably a bit more of a security exposure than folks using
xautolock would be likely to expect.  Getting this committed prior to
the release of 8.0 would thus be welcome.

(I have also verified that the fix is effective for both piewm and
tvtwm.)

Peace,
david
-- 
David H. Wolfskill				david@catwhisker.org
Depriving a girl or boy of an opportunity for education is evil.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.
Comment 2 Martin Wilke freebsd_committer 2009-10-18 12:11:06 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer 2009-10-18 12:11:08 UTC
miwi        2009-10-18 11:10:58 UTC

  FreeBSD ports repository

  Modified files:
    x11/xlockmore        Makefile distinfo 
  Log:
  - Update to 5.29.1
  
  PR:             139676
  Submitted by:   Marius Nuennerich <marius@nuenneri.ch> (maintainer)
  
  Revision  Changes    Path
  1.121     +1 -1      ports/x11/xlockmore/Makefile
  1.64      +3 -3      ports/x11/xlockmore/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"